Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page* (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
index 69f80ab7c2ef6d7e66105fbb74ab8a5738b6d774..3986797928aec66b3e3fe047f7a06369554a3a02 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
@@ -260,7 +260,7 @@ inline float parentTextZoomFactor(LocalFrame* frame) {
template class CORE_TEMPLATE_EXPORT Supplement<LocalFrame>;
LocalFrame* LocalFrame::create(LocalFrameClient* client,
- Page* page,
+ Page& page,
FrameOwner* owner,
InterfaceProvider* interfaceProvider,
InterfaceRegistry* interfaceRegistry) {
@@ -844,12 +844,12 @@ bool LocalFrame::shouldThrottleRendering() const {
}
inline LocalFrame::LocalFrame(LocalFrameClient* client,
- Page* page,
+ Page& page,
FrameOwner* owner,
InterfaceProvider* interfaceProvider,
InterfaceRegistry* interfaceRegistry)
: Frame(client, page, owner, LocalWindowProxyManager::create(*this)),
- m_frameScheduler(page->chromeClient().createFrameScheduler(
+ m_frameScheduler(page.chromeClient().createFrameScheduler(
client->frameBlameContext())),
m_loader(this),
m_navigationScheduler(NavigationScheduler::create(this)),
« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalFrame.h ('k') | third_party/WebKit/Source/core/frame/RemoteFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698