third_party/WebKit/Source/core/frame/LocalFrame.h - Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page* (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalFrame.h

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h

index a2ee86ecae24095cca79b56ad84f1cf42a499e3e..5f274e82dce30ae1a338a1b2157b0bb956726ca4 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.h

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h

@@ -90,7 +90,7 @@ class CORE_EXPORT LocalFrame final : public Frame,

public:

static LocalFrame* create(LocalFrameClient*,

- Page*,

+ Page&,

FrameOwner*,

InterfaceProvider* = nullptr,

InterfaceRegistry* = nullptr);

@@ -231,7 +231,7 @@ class CORE_EXPORT LocalFrame final : public Frame,

friend class FrameNavigationDisabler;

LocalFrame(LocalFrameClient*,

- Page*,

+ Page&,

FrameOwner*,

InterfaceProvider*,

InterfaceRegistry*);