Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: third_party/WebKit/Source/core/frame/Frame.cpp

Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page* (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/Frame.h ('k') | third_party/WebKit/Source/core/frame/LocalFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/Frame.cpp
diff --git a/third_party/WebKit/Source/core/frame/Frame.cpp b/third_party/WebKit/Source/core/frame/Frame.cpp
index a3d935d830d1188a95059f777c4b59cf84ad33d0..e9ea714dc6d75ae8a21f7bbf99f35254ec206376 100644
--- a/third_party/WebKit/Source/core/frame/Frame.cpp
+++ b/third_party/WebKit/Source/core/frame/Frame.cpp
@@ -419,19 +419,17 @@ bool Frame::isFeatureEnabled(WebFeaturePolicyFeature feature) const {
}
Frame::Frame(FrameClient* client,
- Page* page,
+ Page& page,
FrameOwner* owner,
WindowProxyManager* windowProxyManager)
: m_treeNode(this),
- m_page(page),
+ m_page(&page),
m_owner(owner),
m_client(client),
m_windowProxyManager(windowProxyManager),
m_isLoading(false) {
InstanceCounters::incrementCounter(InstanceCounters::FrameCounter);
- DCHECK(m_page);
-
if (m_owner)
m_owner->setContentFrame(*this);
else
« no previous file with comments | « third_party/WebKit/Source/core/frame/Frame.h ('k') | third_party/WebKit/Source/core/frame/LocalFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698