third_party/WebKit/Source/core/frame/Frame.h - Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Frame.h

Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page* (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/Frame.h

diff --git a/third_party/WebKit/Source/core/frame/Frame.h b/third_party/WebKit/Source/core/frame/Frame.h

index e84cdabc262b1f79297278ee84405a3bce6262bb..439442796dcaac53b3e79f2d45df0d4145058403 100644

--- a/third_party/WebKit/Source/core/frame/Frame.h

+++ b/third_party/WebKit/Source/core/frame/Frame.h

@@ -156,7 +156,7 @@ class CORE_EXPORT Frame : public GarbageCollectedFinalized<Frame> {

bool isFeatureEnabled(WebFeaturePolicyFeature) const;

protected:

- Frame(FrameClient*, Page*, FrameOwner*, WindowProxyManager*);

+ Frame(FrameClient*, Page&, FrameOwner*, WindowProxyManager*);

mutable FrameTree m_treeNode;