Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2762133003: Revert of Delete class MockCongestionController. (Closed)

Created:
3 years, 9 months ago by skvlad
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete class MockCongestionController. (patchset #4 id:60001 of https://codereview.webrtc.org/2762023004/ ) Reason for revert: This is breaking downstream build. Original issue's description: > Delete class MockCongestionController. > > It became unused in cl https://codereview.webrtc.org/2516983004. > > BUG=None > > Review-Url: https://codereview.webrtc.org/2762023004 > Cr-Commit-Position: refs/heads/master@{#17325} > Committed: https://chromium.googlesource.com/external/webrtc/+/d19bcb7116d527b5d0b7426468490e72b03358ca TBR=stefan@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2762133003 Cr-Commit-Position: refs/heads/master@{#17330} Committed: https://chromium.googlesource.com/external/webrtc/+/e27f1e764ef45f6489cf192de843ca912a05a101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -36 lines) Patch
M webrtc/audio/audio_send_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h View 1 chunk +73 lines, -0 lines 0 comments Download
D webrtc/modules/congestion_controller/include/mock/mock_congestion_observer.h View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
skvlad
Created Revert of Delete class MockCongestionController.
3 years, 9 months ago (2017-03-21 20:15:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2762133003/1
3 years, 9 months ago (2017-03-21 20:15:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/e27f1e764ef45f6489cf192de843ca912a05a101
3 years, 9 months ago (2017-03-21 20:16:04 UTC) #6
nisse-webrtc
3 years, 9 months ago (2017-03-22 09:01:22 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2766133002/ by nisse@webrtc.org.

The reason for reverting is: Problem was the rename of the include file. Intend
to keep the old name for now, and then reland..

Powered by Google App Engine
This is Rietveld 408576698