Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2762023004: Delete class MockCongestionController. (Closed)

Created:
3 years, 9 months ago by nisse-webrtc
Modified:
3 years, 9 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete class MockCongestionController. It became unused in cl https://codereview.webrtc.org/2516983004. BUG=None Review-Url: https://codereview.webrtc.org/2762023004 Cr-Commit-Position: refs/heads/master@{#17325} Committed: https://chromium.googlesource.com/external/webrtc/+/d19bcb7116d527b5d0b7426468490e72b03358ca

Patch Set 1 #

Patch Set 2 : Also delete obsolete TODO and using declaration. #

Total comments: 2

Patch Set 3 : Renamed mock_congestion_controller.h --> mock_congestion_observer.h. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -75 lines) Patch
M webrtc/audio/audio_send_stream_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h View 1 2 1 chunk +0 lines, -73 lines 0 comments Download
A webrtc/modules/congestion_controller/include/mock/mock_congestion_observer.h View 1 2 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
nisse-webrtc
PTAL
3 years, 9 months ago (2017-03-21 12:23:36 UTC) #4
stefan-webrtc
lgtm https://codereview.webrtc.org/2762023004/diff/20001/webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h File webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h (right): https://codereview.webrtc.org/2762023004/diff/20001/webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h#newcode12 webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h:12: #define WEBRTC_MODULES_CONGESTION_CONTROLLER_INCLUDE_MOCK_MOCK_CONGESTION_CONTROLLER_H_ Maybe rename the file to mock_congestion_observer.h?
3 years, 9 months ago (2017-03-21 15:28:57 UTC) #7
nisse-webrtc
https://codereview.webrtc.org/2762023004/diff/20001/webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h File webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h (right): https://codereview.webrtc.org/2762023004/diff/20001/webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h#newcode12 webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h:12: #define WEBRTC_MODULES_CONGESTION_CONTROLLER_INCLUDE_MOCK_MOCK_CONGESTION_CONTROLLER_H_ On 2017/03/21 15:28:57, stefan-webrtc wrote: > Maybe ...
3 years, 9 months ago (2017-03-21 15:31:45 UTC) #8
nisse-webrtc
On 2017/03/21 15:31:45, nisse-webrtc wrote: > https://codereview.webrtc.org/2762023004/diff/20001/webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h > File > webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h > (right): > > ...
3 years, 9 months ago (2017-03-21 15:36:53 UTC) #9
nisse-webrtc
Renaming done. Finding a suitable gn target was more difficult than I expected, so not ...
3 years, 9 months ago (2017-03-21 15:47:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2762023004/40001
3 years, 9 months ago (2017-03-21 15:48:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/builds/2691) ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 9 months ago (2017-03-21 15:49:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2762023004/60001
3 years, 9 months ago (2017-03-21 15:52:24 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/external/webrtc/+/d19bcb7116d527b5d0b7426468490e72b03358ca
3 years, 9 months ago (2017-03-21 16:41:13 UTC) #21
skvlad
On 2017/03/21 16:41:13, commit-bot: I haz the power wrote: > Committed patchset #4 (id:60001) as ...
3 years, 9 months ago (2017-03-21 20:15:06 UTC) #22
skvlad
3 years, 9 months ago (2017-03-21 20:15:47 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.webrtc.org/2762133003/ by skvlad@webrtc.org.

The reason for reverting is: This is breaking downstream build..

Powered by Google App Engine
This is Rietveld 408576698