Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Issue 2755803004: Delete video_coding_robustness_unittest.cc (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete video_coding_robustness_unittest.cc BUG=none Review-Url: https://codereview.webrtc.org/2755803004 Cr-Commit-Position: refs/heads/master@{#17312} Committed: https://chromium.googlesource.com/external/webrtc/+/a5c18d73121f9fe3b877698f099dfaa47beea90b

Patch Set 1 #

Patch Set 2 : Rebase and restore one Create function and provide a dummy implementation for SetReceiverRobustness… #

Patch Set 3 : Bring back morar impl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -311 lines) Patch
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/include/video_coding.h View 1 2 3 chunks +6 lines, -19 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.cc View 1 2 1 chunk +3 lines, -26 lines 0 comments Download
D webrtc/modules/video_coding/video_coding_robustness_unittest.cc View 1 chunk +0 lines, -237 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver.cc View 1 2 3 chunks +8 lines, -24 lines 0 comments Download

Messages

Total messages: 29 (18 generated)
tommi
Here's another test that I don't think is that useful (it doesn't respect* the design ...
3 years, 9 months ago (2017-03-16 22:18:11 UTC) #4
tommi
+henrik.lundin as there are TODOs in video_receiver.cc to take a look at.
3 years, 9 months ago (2017-03-16 22:26:49 UTC) #6
hlundin-webrtc
I think we can safely say that soft NACK and RPSI are deprecated. To the ...
3 years, 9 months ago (2017-03-17 08:19:23 UTC) #9
tommi
Rebase and restore one Create function and provide a dummy implementation for SetReceiverRobustnessMode
3 years, 9 months ago (2017-03-17 13:27:28 UTC) #10
tommi
I brought back one VideoCodecModule::Create variant and a stub function for SetReceiverRobustnessMode that simply returns ...
3 years, 9 months ago (2017-03-17 13:29:20 UTC) #13
tommi
Bring back morar impl
3 years, 9 months ago (2017-03-17 18:05:17 UTC) #16
tommi
brought back the currently implemented parts of SetReceiverRobustnessMode. ptal
3 years, 9 months ago (2017-03-17 18:09:02 UTC) #19
stefan-webrtc
lgtm
3 years, 9 months ago (2017-03-20 15:47:11 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2755803004/40001
3 years, 9 months ago (2017-03-20 17:02:20 UTC) #25
mflodman
lgtm
3 years, 9 months ago (2017-03-20 17:16:57 UTC) #26
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 17:43:29 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/a5c18d73121f9fe3b877698f0...

Powered by Google App Engine
This is Rietveld 408576698