Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: webrtc/modules/video_coding/include/video_coding.h

Issue 2755803004: Delete video_coding_robustness_unittest.cc (Closed)
Patch Set: Bring back morar impl Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_coding/BUILD.gn ('k') | webrtc/modules/video_coding/video_coding_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/include/video_coding.h
diff --git a/webrtc/modules/video_coding/include/video_coding.h b/webrtc/modules/video_coding/include/video_coding.h
index 5e02eab5750350dbac6936292a5e5104ca517b31..531f45a87ad798a8e5f227d75c5bffbe3791cb82 100644
--- a/webrtc/modules/video_coding/include/video_coding.h
+++ b/webrtc/modules/video_coding/include/video_coding.h
@@ -71,23 +71,9 @@ class VideoCodingModule : public Module {
public:
enum SenderNackMode { kNackNone, kNackAll, kNackSelective };
- enum ReceiverRobustness { kNone, kHardNack, kSoftNack, kReferenceSelection };
-
+ // DEPRECATED.
static VideoCodingModule* Create(Clock* clock, EventFactory* event_factory);
- static VideoCodingModule* Create(
- Clock* clock,
- VCMQMSettingsCallback* qm_settings_callback,
- NackSender* nack_sender,
- KeyFrameRequestSender* keyframe_request_sender,
- EncodedImageCallback* pre_decode_image_callback);
-
- static VideoCodingModule* Create(
- Clock* clock,
- EventFactory* event_factory,
- NackSender* nack_sender,
- KeyFrameRequestSender* keyframe_request_sender);
-
// Get supported codec settings using codec type
//
// Input:
@@ -396,11 +382,11 @@ class VideoCodingModule : public Module {
// Robustness APIs
+ // DEPRECATED.
// Set the receiver robustness mode. The mode decides how the receiver
- // responds to losses in the stream. The type of counter-measure (soft or
- // hard NACK, dual decoder, RPS, etc.) is selected through the
- // robustnessMode parameter. The errorMode parameter decides if it is
- // allowed to display frames corrupted by losses. Note that not all
+ // responds to losses in the stream. The type of counter-measure is selected
+ // through the robustnessMode parameter. The errorMode parameter decides if it
+ // is allowed to display frames corrupted by losses. Note that not all
// combinations of the two parameters are feasible. An error will be
// returned for invalid combinations.
// Input:
@@ -409,6 +395,7 @@ class VideoCodingModule : public Module {
//
// Return value : VCM_OK, on success;
// < 0, on error.
+ enum ReceiverRobustness { kNone, kHardNack };
virtual int SetReceiverRobustnessMode(ReceiverRobustness robustnessMode,
VCMDecodeErrorMode errorMode) = 0;
« no previous file with comments | « webrtc/modules/video_coding/BUILD.gn ('k') | webrtc/modules/video_coding/video_coding_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698