Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2755663004: mac: Fix screen capture for whole-desktop capture. (Closed)

Created:
3 years, 9 months ago by Sergey Ulanov
Modified:
3 years, 9 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/branch-heads/58
Project:
webrtc
Visibility:
Public.

Description

mac: Fix screen capture for whole-desktop capture. DisplayStream refresh rects are in display coordinates. When the whole screen is being captured, the coordinates passed to the ScreenCapturerHelper need to be in screen coordinates. This CL translates display coordinates to screen coordinates for whole screen capture. BUG=chromium:699672 Review-Url: https://codereview.webrtc.org/2740823002 Cr-Commit-Position: refs/heads/master@{#17153} (cherry picked from commit 31bbee73a029376ca5a6f74e3d5bf224053a6208) Review-Url: https://codereview.webrtc.org/2755663004 . Cr-Commit-Position: refs/branch-heads/58@{#4} Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937} Committed: https://chromium.googlesource.com/external/webrtc/+/5810d27a9b13fe581282acc33350525be43e6f95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M webrtc/modules/desktop_capture/screen_capturer_mac.mm View 4 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Sergey Ulanov
3 years, 9 months ago (2017-03-15 18:40:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5810d27a9b13fe581282acc33350525be43e6f95.

Powered by Google App Engine
This is Rietveld 408576698