mac: Fix screen capture for whole-desktop capture.

mac: Fix screen capture for whole-desktop capture.

DisplayStream refresh rects are in display coordinates. When the whole screen is
being captured, the coordinates passed to the ScreenCapturerHelper need to be in
screen coordinates. This CL translates display coordinates to screen
coordinates for whole screen capture.

BUG=chromium:699672
Review-Url: https://codereview.webrtc.org/2740823002
Cr-Commit-Position: refs/heads/master@{#17153}
Committed: https://chromium.googlesource.com/external/webrtc/+/31bbee73a029376ca5a6f74e3d5bf224053a6208

[erikchen, 2017-03-08 23:51:37]

erikchen@chromium.org changed reviewers:
+ sergeyu@chromium.org

[erikchen, 2017-03-08 23:51:38]

sergeyu: Please review.

I've tested that this works for both single-display and whole-screen capture. I
don't have any retina, secondary monitors to test with, but I believe that the
translation by config.pixel_bounds.top_left() should still be correct
[confirmation would be appreciated].

[Sergey Ulanov, 2017-03-09 20:46:38]

On 2017/03/08 23:51:38, erikchen wrote:
> sergeyu: Please review.
> 
> I've tested that this works for both single-display and whole-screen capture.
I
> don't have any retina, secondary monitors to test with, but I believe that the
> translation by config.pixel_bounds.top_left() should still be correct
> [confirmation would be appreciated].

On mixed-DPI systems we only capture displays that have the same resolution as
the main one. See
https://codesearch.chromium.org/chromium/src/third_party/webrtc/modules/deskt...

[erikchen, 2017-03-09 20:50:03]

On 2017/03/09 20:46:38, Sergey Ulanov wrote:
> On 2017/03/08 23:51:38, erikchen wrote:
> > sergeyu: Please review.
> > 
> > I've tested that this works for both single-display and whole-screen
capture.
> I
> > don't have any retina, secondary monitors to test with, but I believe that
the
> > translation by config.pixel_bounds.top_left() should still be correct
> > [confirmation would be appreciated].
> 
> On mixed-DPI systems we only capture displays that have the same resolution as
> the main one. See
>
https://codesearch.chromium.org/chromium/src/third_party/webrtc/modules/deskt...

I think this CL has the appropriate behavior for 2 screens, both with retina
DPI, but I wasn't able to test this locally.

[Sergey Ulanov, 2017-03-09 20:55:06]

sergeyu@chromium.org changed reviewers:
+ nicholss@chromium.org

[Sergey Ulanov, 2017-03-09 20:55:07]

LGTM, thanks for fixing it quickly!

+nicholss@, FYI
Scott, if you have time, please verify that this fixes the problem for CRD. It
it works then I think we should get it merged to M58

[erikchen, 2017-03-09 21:00:03]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2017-03-09 21:00:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-09 21:19:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489093203639950, "parent_rev":
"d64862ac1b672b6e9fba25a1363208407b1cd4f4", "commit_rev":
"31bbee73a029376ca5a6f74e3d5bf224053a6208"}

[commit-bot: I haz the power, 2017-03-09 21:19:07]

Description was changed from

==========
mac: Fix screen capture for whole-desktop capture.

DisplayStream refresh rects are in display coordinates. When the whole screen is
being captured, the coordinates passed to the ScreenCapturerHelper need to be in
screen coordinates. This CL translates display coordinates to screen
coordinates for whole screen capture.

BUG=chromium:699672
==========

to

==========
mac: Fix screen capture for whole-desktop capture.

DisplayStream refresh rects are in display coordinates. When the whole screen is
being captured, the coordinates passed to the ScreenCapturerHelper need to be in
screen coordinates. This CL translates display coordinates to screen
coordinates for whole screen capture.

BUG=chromium:699672

Review-Url: https://codereview.webrtc.org/2740823002
Cr-Commit-Position: refs/heads/master@{#17153}
Committed:
https://chromium.googlesource.com/external/webrtc/+/31bbee73a029376ca5a6f74e3...
==========

[commit-bot: I haz the power, 2017-03-09 21:19:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/31bbee73a029376ca5a6f74e3...