Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2755663003: Remove unused RealTimeTemporalLayers. (Closed)

Created:
3 years, 9 months ago by pbos-webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused RealTimeTemporalLayers. BUG=webrtc:7349 R=sprang@webrtc.org, marpan@webrtc.org Review-Url: https://codereview.webrtc.org/2755663003 . Cr-Commit-Position: refs/heads/master@{#17262} Committed: https://chromium.googlesource.com/external/webrtc/+/e01326fbd7ddebf18d912a0cc44a2fef1be47a73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -369 lines) Patch
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc View 1 chunk +0 lines, -311 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/temporal_layers.h View 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/modules/video_coding/video_sender_unittest.cc View 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pbos-webrtc
PTAL
3 years, 9 months ago (2017-03-15 17:14:45 UTC) #1
pbos-webrtc
stefan@ can we remove these, or are they likely to become used?
3 years, 9 months ago (2017-03-15 17:29:37 UTC) #3
sprang_webrtc
I tried this for screesharing recently but it did not work well. Fine with nuking ...
3 years, 9 months ago (2017-03-15 18:07:11 UTC) #5
pbos-webrtc
3 years, 9 months ago (2017-03-15 18:08:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e01326fbd7ddebf18d912a0cc44a2fef1be47a73 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698