Ignore packets sent on old network route when receiving feedback.

Ignore packets sent on old network route when receiving feedback.

BUG=webrtc:7347
R=philipel@webrtc.org

Review-Url: https://codereview.webrtc.org/2755553003 .
Cr-Commit-Position: refs/heads/master@{#17243}
Committed: https://chromium.googlesource.com/external/webrtc/+/9ea46b52864d57d943347b27015f7689f2d00dec

[stefan-webrtc, 2017-03-15 10:17:40]

stefan@webrtc.org changed reviewers:
+ philipel@webrtc.org

[stefan-webrtc, 2017-03-15 10:19:24]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 10:19:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[philipel, 2017-03-15 10:38:37]

https://codereview.webrtc.org/2755553003/diff/1/webrtc/modules/congestion_con...
File webrtc/modules/congestion_controller/transport_feedback_adapter.cc (right):

https://codereview.webrtc.org/2755553003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/transport_feedback_adapter.cc:51:
send_time_history_.AddAndRemoveOld(PacketFeedback(
I know it's more of a refactoring task, but having a ctor for PacketFeedback
that does not take arrival time and send time as parameters would make this
segment a lot cleaner.

https://codereview.webrtc.org/2755553003/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc
(right):

https://codereview.webrtc.org/2755553003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc:35: void
AddPacketWithSendTime(uint16_t sequence_number,
A test where we save/restore the network ids would be good.

[commit-bot: I haz the power, 2017-03-15 10:44:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 10:44:29]

Dry run: This issue passed the CQ dry run.

[stefan-webrtc, 2017-03-15 10:50:50]

Comments addressed.

[stefan-webrtc, 2017-03-15 10:51:39]

https://codereview.webrtc.org/2755553003/diff/1/webrtc/modules/congestion_con...
File webrtc/modules/congestion_controller/transport_feedback_adapter.cc (right):

https://codereview.webrtc.org/2755553003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/transport_feedback_adapter.cc:51:
send_time_history_.AddAndRemoveOld(PacketFeedback(
On 2017/03/15 10:38:37, philipel wrote:
> I know it's more of a refactoring task, but having a ctor for PacketFeedback
> that does not take arrival time and send time as parameters would make this
> segment a lot cleaner.

Done.

https://codereview.webrtc.org/2755553003/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc
(right):

https://codereview.webrtc.org/2755553003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc:35: void
AddPacketWithSendTime(uint16_t sequence_number,
On 2017/03/15 10:38:37, philipel wrote:
> A test where we save/restore the network ids would be good.

Done.

[philipel, 2017-03-15 11:38:46]

lgtm

[stefan-webrtc, 2017-03-15 11:40:29]

Description was changed from

==========
Ignore packets sent on old network route when receiving feedback.

BUG=webrtc:7347
==========

to

==========
Ignore packets sent on old network route when receiving feedback.

BUG=webrtc:7347
R=philipel@webrtc.org

Review-Url: https://codereview.webrtc.org/2755553003 .
Cr-Commit-Position: refs/heads/master@{#17243}
Committed:
https://chromium.googlesource.com/external/webrtc/+/9ea46b52864d57d943347b270...
==========

[stefan-webrtc, 2017-03-15 11:40:31]

Committed patchset #2 (id:20001) manually as
9ea46b52864d57d943347b27015f7689f2d00dec (presubmit successful).