Ignore packets sent on old network route when receiving feedback.

webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 14 matching lines @@
 class SendTimeHistoryTest : public ::testing::Test {
  protected:
   SendTimeHistoryTest()
       : clock_(0), history_(&clock_, kDefaultHistoryLengthMs) {}
   ~SendTimeHistoryTest() {}
 
   virtual void SetUp() {}
 
   virtual void TearDown() {}
 
   void AddPacketWithSendTime(uint16_t sequence_number,

[philipel, 2017/03/15 10:38:37]

A test where we save/restore the network ids would be good.

[stefan-webrtc, 2017/03/15 10:51:39]

Done.

                              size_t length,
                              int64_t send_time_ms,
                              const PacedPacketInfo& pacing_info) {
-    history_.AddAndRemoveOld(sequence_number, length, pacing_info);
+    PacketFeedback packet(clock_.TimeInMilliseconds(), -1, -1, sequence_number,
+                          length, 0, 0, pacing_info);
+    history_.AddAndRemoveOld(packet);
     history_.OnSentPacket(sequence_number, send_time_ms);
   }
 
   webrtc::SimulatedClock clock_;
   SendTimeHistory history_;
 };
 
 TEST_F(SendTimeHistoryTest, AddRemoveOne) {
   const uint16_t kSeqNo = 10;
   // TODO(philipel): Fix PacedPacketInfo constructor?
@@ skipping 40 matching lines @@
   const PacedPacketInfo kPacingInfo(1, 2, 200);
   for (size_t i = 0; i < num_items; ++i) {
     sent_packets.push_back(PacketFeedback(0, static_cast<int64_t>(i),
                                           static_cast<uint16_t>(i), kPacketSize,
                                           kPacingInfo));
     received_packets.push_back(PacketFeedback(
         static_cast<int64_t>(i) + kTransmissionTime, 0,
         static_cast<uint16_t>(i), kPacketSize, PacedPacketInfo()));
   }
   for (size_t i = 0; i < num_items; ++i) {
-    history_.AddAndRemoveOld(sent_packets[i].sequence_number,
-                             sent_packets[i].payload_size,
-                             PacedPacketInfo(1, 2, 200));
+    PacketFeedback packet = sent_packets[i];
+    packet.arrival_time_ms = -1;
+    packet.send_time_ms = -1;
+    history_.AddAndRemoveOld(packet);
   }
   for (size_t i = 0; i < num_items; ++i)
     history_.OnSentPacket(sent_packets[i].sequence_number,
                           sent_packets[i].send_time_ms);
   std::random_shuffle(received_packets.begin(), received_packets.end());
   for (size_t i = 0; i < num_items; ++i) {
     PacketFeedback packet = received_packets[i];
     EXPECT_TRUE(history_.GetFeedback(&packet, false));
     PacketFeedback sent_packet = sent_packets[packet.sequence_number];
     sent_packet.arrival_time_ms = packet.arrival_time_ms;
@@ skipping 92 matching lines @@
                         packets[2].send_time_ms, packets[2].pacing_info);
 
   PacketFeedback packet2(0, 0, packets[1].sequence_number, 0, kPacingInfo1);
   EXPECT_TRUE(history_.GetFeedback(&packet2, true));
   EXPECT_EQ(packets[1], packet2);
 
   PacketFeedback packet3(0, 0, packets[2].sequence_number, 0, kPacingInfo2);
   EXPECT_TRUE(history_.GetFeedback(&packet3, true));
   EXPECT_EQ(packets[2], packet3);
 }
-
-TEST_F(SendTimeHistoryTest, Clear) {
-  const uint16_t kSeqNo = 1;
-  const int64_t kTimestamp = 2;
-  const PacedPacketInfo kPacingInfo(0, 5, 1200);
-
-  PacketFeedback packets[] = {{0, kTimestamp, kSeqNo, 0, kPacingInfo},
-                          {0, kTimestamp + 1, kSeqNo + 1, 0, kPacingInfo}};
-
-  AddPacketWithSendTime(packets[0].sequence_number, packets[0].payload_size,
-                        packets[0].send_time_ms, kPacingInfo);
-  AddPacketWithSendTime(packets[1].sequence_number, packets[1].payload_size,
-                        packets[1].send_time_ms, kPacingInfo);
-  PacketFeedback info(0, 0, packets[0].sequence_number, 0, kPacingInfo);
-  EXPECT_TRUE(history_.GetFeedback(&info, true));
-  EXPECT_EQ(packets[0], info);
-
-  history_.Clear();
-
-  PacketFeedback info2(0, 0, packets[1].sequence_number, 0, kPacingInfo);
-  EXPECT_FALSE(history_.GetFeedback(&info2, true));
-}
-
 }  // namespace test
 }  // namespace webrtc