Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2754543005: Revert of Save width/height of SPS nalus and restore them on the first packet of an IDR. (Closed)

Created:
3 years, 9 months ago by philipel
Modified:
3 years, 9 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Save width/height of SPS nalus and restore them on the first packet of an IDR. (patchset #6 id:100001 of https://codereview.webrtc.org/2750633003/ ) Reason for revert: Breaks build bots. Original issue's description: > Save width/height of SPS nalus and restore them on the first packet of an IDR. > > It appears that for some H264 streams that the width/height is not set for > the first packet of the IDR but in the packet containing the SPS/PPS. > > BUG=chromium:698088, webrtc:7139 > > Review-Url: https://codereview.webrtc.org/2750633003 > Cr-Commit-Position: refs/heads/master@{#17239} > Committed: https://chromium.googlesource.com/external/webrtc/+/620d75f5befe1387bc457bc3ec5ad0158c4e6697 TBR=stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:698088, webrtc:7139 Review-Url: https://codereview.webrtc.org/2754543005 Cr-Commit-Position: refs/heads/master@{#17250} Committed: https://chromium.googlesource.com/external/webrtc/+/be35a008ef39bc52a1ac30e763057d0ab5df824a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -43 lines) Patch
M webrtc/modules/video_coding/h264_sps_pps_tracker.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/h264_sps_pps_tracker.cc View 5 chunks +1 line, -9 lines 0 comments Download
M webrtc/modules/video_coding/h264_sps_pps_tracker_unittest.cc View 3 chunks +0 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
philipel
Created Revert of Save width/height of SPS nalus and restore them on the first packet ...
3 years, 9 months ago (2017-03-15 14:13:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2754543005/1
3 years, 9 months ago (2017-03-15 14:13:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/be35a008ef39bc52a1ac30e763057d0ab5df824a
3 years, 9 months ago (2017-03-15 14:13:20 UTC) #6
philipel
3 years, 9 months ago (2017-03-15 14:19:43 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2751843003/ by philipel@webrtc.org.

The reason for reverting is: fix.

Powered by Google App Engine
This is Rietveld 408576698