Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2751843003: Reland of Save width/height of SPS nalus and restore them on the first packet of an IDR. (Closed)

Created:
3 years, 9 months ago by philipel
Modified:
3 years, 9 months ago
Reviewers:
stefan-webrtc, Stefan
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Save width/height of SPS nalus and restore them on the first packet of an IDR. (patchset #1 id:1 of https://codereview.webrtc.org/2754543005/ ) Reason for revert: fix Original issue's description: > Revert of Save width/height of SPS nalus and restore them on the first packet of an IDR. (patchset #6 id:100001 of https://codereview.webrtc.org/2750633003/ ) > > Reason for revert: > Breaks build bots. > > Original issue's description: > > Save width/height of SPS nalus and restore them on the first packet of an IDR. > > > > It appears that for some H264 streams that the width/height is not set for > > the first packet of the IDR but in the packet containing the SPS/PPS. > > > > BUG=chromium:698088, webrtc:7139 > > > > Review-Url: https://codereview.webrtc.org/2750633003 > > Cr-Commit-Position: refs/heads/master@{#17239} > > Committed: https://chromium.googlesource.com/external/webrtc/+/620d75f5befe1387bc457bc3ec5ad0158c4e6697 > > TBR=stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:698088, webrtc:7139 > > Review-Url: https://codereview.webrtc.org/2754543005 > Cr-Commit-Position: refs/heads/master@{#17250} > Committed: https://chromium.googlesource.com/external/webrtc/+/be35a008ef39bc52a1ac30e763057d0ab5df824a TBR=stefan@webrtc.org BUG=chromium:698088, webrtc:7139 Review-Url: https://codereview.webrtc.org/2751843003 Cr-Commit-Position: refs/heads/master@{#17289} Committed: https://chromium.googlesource.com/external/webrtc/+/6585f7087cbd087ce6dbc2779199d3b79ab36236

Patch Set 1 #

Patch Set 2 : Windows fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M webrtc/modules/video_coding/h264_sps_pps_tracker.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/h264_sps_pps_tracker.cc View 1 5 chunks +12 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/h264_sps_pps_tracker_unittest.cc View 1 3 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
philipel
Created Reland of Save width/height of SPS nalus and restore them on the first packet ...
3 years, 9 months ago (2017-03-15 14:19:44 UTC) #1
stefan-webrtc
On 2017/03/15 14:19:44, philipel wrote: > Created Reland of Save width/height of SPS nalus and ...
3 years, 9 months ago (2017-03-15 14:48:20 UTC) #2
philipel
On 2017/03/15 14:48:20, stefan-webrtc wrote: > On 2017/03/15 14:19:44, philipel wrote: > > Created Reland ...
3 years, 9 months ago (2017-03-15 15:02:21 UTC) #3
philipel
PTAL
3 years, 9 months ago (2017-03-17 12:00:42 UTC) #4
Stefan
lgtm
3 years, 9 months ago (2017-03-17 12:41:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2751843003/140001
3 years, 9 months ago (2017-03-17 12:42:01 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 13:12:39 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:140001) as
https://chromium.googlesource.com/external/webrtc/+/6585f7087cbd087ce6dbc2779...

Powered by Google App Engine
This is Rietveld 408576698