Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2753783002: Delete VP8 feedback mode. (Closed)

Created:
3 years, 9 months ago by nisse-webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman, danilchap
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete VP8 feedback mode. It depends on RTCP RPSI and SLI messages, which are being deleted. TBR=stefan@webrtc.org # TODO comments added to common_types.h BUG=webrtc:7338 Review-Url: https://codereview.webrtc.org/2753783002 Cr-Commit-Position: refs/heads/master@{#17314} Committed: https://chromium.googlesource.com/external/webrtc/+/3257b16156ee3065edbc722c6e215b58a8914ad2

Patch Set 1 #

Total comments: 7

Patch Set 2 : Delete RPSI-related simulcast tests. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -608 lines) Patch
M webrtc/common_types.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
D webrtc/modules/video_coding/codecs/vp8/reference_picture_selection.h View 1 chunk +0 lines, -76 lines 0 comments Download
D webrtc/modules/video_coding/codecs/vp8/reference_picture_selection.cc View 1 chunk +0 lines, -132 lines 0 comments Download
D webrtc/modules/video_coding/codecs/vp8/reference_picture_selection_unittest.cc View 1 chunk +0 lines, -100 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc View 1 3 chunks +0 lines, -9 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 1 2 chunks +0 lines, -142 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 2 11 chunks +11 lines, -109 lines 0 comments Download
M webrtc/modules/video_coding/include/video_codec_interface.h View 2 chunks +0 lines, -8 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 2 3 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
nisse-webrtc
PTAL, this is part two, extracted from cl https://codereview.webrtc.org/2742383004/ Erik: Do you know the purpose ...
3 years, 9 months ago (2017-03-15 08:12:33 UTC) #2
danilchap
looks good, but I'm not familiar enough with video codecs code to be sure. https://codereview.webrtc.org/2753783002/diff/1/webrtc/video/vie_encoder.cc ...
3 years, 9 months ago (2017-03-15 09:05:33 UTC) #3
nisse-webrtc
https://codereview.webrtc.org/2753783002/diff/1/webrtc/video/vie_encoder.cc File webrtc/video/vie_encoder.cc (right): https://codereview.webrtc.org/2753783002/diff/1/webrtc/video/vie_encoder.cc#newcode662 webrtc/video/vie_encoder.cc:662: // TODO(nisse): Delete. On 2017/03/15 09:05:32, danilchap wrote: > ...
3 years, 9 months ago (2017-03-15 09:29:46 UTC) #4
danilchap
https://codereview.webrtc.org/2753783002/diff/1/webrtc/video/vie_encoder.cc File webrtc/video/vie_encoder.cc (right): https://codereview.webrtc.org/2753783002/diff/1/webrtc/video/vie_encoder.cc#newcode662 webrtc/video/vie_encoder.cc:662: // TODO(nisse): Delete. On 2017/03/15 09:29:46, nisse-webrtc wrote: > ...
3 years, 9 months ago (2017-03-15 12:00:16 UTC) #5
sprang_webrtc
lgtm https://codereview.webrtc.org/2753783002/diff/1/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h File webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h (right): https://codereview.webrtc.org/2753783002/diff/1/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h#newcode574 webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h:574: // TODO(nisse): Rename, refactor or delete test? I ...
3 years, 9 months ago (2017-03-20 16:22:30 UTC) #8
nisse-webrtc
https://codereview.webrtc.org/2753783002/diff/1/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h File webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h (right): https://codereview.webrtc.org/2753783002/diff/1/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h#newcode574 webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h:574: // TODO(nisse): Rename, refactor or delete test? On 2017/03/20 ...
3 years, 9 months ago (2017-03-21 07:26:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2753783002/40001
3 years, 9 months ago (2017-03-21 08:51:57 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 08:54:18 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/3257b16156ee3065edbc722c6...

Powered by Google App Engine
This is Rietveld 408576698