webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc - Issue 2753783002: Delete VP8 feedback mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

Issue 2753783002: Delete VP8 feedback mode. (Closed)

Patch Set: Rebased. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/reference_picture_selection_unittest.cc ('k') | webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc b/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

index 3aaa9c7dc860398cb0bea98c50bb58d2bdc93610..8cef40d42e807afec74299b1f7af84b87a1276e3 100644

--- a/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

@@ -75,9 +75,6 @@ int VerifyCodec(const webrtc::VideoCodec* inst) {

if (inst->width <= 1 || inst->height <= 1) {

return WEBRTC_VIDEO_CODEC_ERR_PARAMETER;

}

- if (inst->VP8().feedbackModeOn && inst->numberOfSimulcastStreams > 1) {

- return WEBRTC_VIDEO_CODEC_ERR_PARAMETER;

- }

if (inst->VP8().automaticResizeOn && inst->numberOfSimulcastStreams > 1) {

return WEBRTC_VIDEO_CODEC_ERR_PARAMETER;

}