Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 2749493002: Change the type of session_id() from string to int64_t. (Closed)

Created:
3 years, 9 months ago by Zhi Huang
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change the type of session_id() from string to int64_t. BUG=webrtc:7311 Review-Url: https://codereview.webrtc.org/2749493002 Cr-Commit-Position: refs/heads/master@{#17215} Committed: https://chromium.googlesource.com/external/webrtc/+/30e0da4a65d4ded14a9158b61548ce09d7cc95c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M webrtc/api/ortc/sessiondescription.h View 2 chunks +5 lines, -8 lines 0 comments Download
M webrtc/api/ortc/sessiondescription_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Zhi Huang
Hi Taylor, This is a follow up CL to address the comments about type of ...
3 years, 9 months ago (2017-03-13 04:25:43 UTC) #4
Taylor Brandstetter
lgtm
3 years, 9 months ago (2017-03-13 17:51:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2749493002/1
3 years, 9 months ago (2017-03-13 17:58:22 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 18:00:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/30e0da4a65d4ded14a9158b61...

Powered by Google App Engine
This is Rietveld 408576698