Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: webrtc/api/ortc/sessiondescription.h

Issue 2749493002: Change the type of session_id() from string to int64_t. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/ortc/sessiondescription_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/ortc/sessiondescription.h
diff --git a/webrtc/api/ortc/sessiondescription.h b/webrtc/api/ortc/sessiondescription.h
index 18a48e0878b54da5628127290bb9939b98490494..52f9b0c93c2d9907b3abb27b396a7bf1ec6d14b1 100644
--- a/webrtc/api/ortc/sessiondescription.h
+++ b/webrtc/api/ortc/sessiondescription.h
@@ -19,19 +19,16 @@ namespace webrtc {
// A structured representation of an SDP session description.
class SessionDescription {
public:
- SessionDescription(std::string session_id, std::string session_version)
- : session_id_(std::move(session_id)),
- session_version_(std::move(session_version)) {}
+ SessionDescription(int64_t session_id, std::string session_version)
+ : session_id_(session_id), session_version_(std::move(session_version)) {}
// https://tools.ietf.org/html/rfc4566#section-5.2
// o=<username> <sess-id> <sess-version> <nettype> <addrtype>
// <unicast-address>
// session_id_ is the "sess-id" field.
// session_version_ is the "sess-version" field.
- const std::string& session_id() const { return session_id_; }
- void set_session_id(std::string session_id) {
- session_id_ = std::move(session_id);
- }
+ int64_t session_id() { return session_id_; }
+ void set_session_id(int64_t session_id) { session_id_ = session_id; }
const std::string& session_version() const { return session_version_; }
void set_session_version(std::string session_version) {
@@ -39,7 +36,7 @@ class SessionDescription {
}
private:
- std::string session_id_;
+ int64_t session_id_;
std::string session_version_;
};
« no previous file with comments | « no previous file | webrtc/api/ortc/sessiondescription_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698