Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2742743002: Revert of Delete cryptstring.h and cryptstring.cc. (Closed)

Created:
3 years, 9 months ago by nisse-webrtc
Modified:
3 years, 9 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete cryptstring.h and cryptstring.cc. (patchset #1 id:1 of https://codereview.webrtc.org/2740633003/ ) Reason for revert: It turns out cryptstring was used by Chrome. In the xmpp code recently moved there from webrtc. So this code has to be moved too, it canät just be deleted. Original issue's description: > Delete cryptstring.h and cryptstring.cc. > > They became unused with cl https://codereview.webrtc.org/2731673002/ > > BUG=webrtc:6424 > > Review-Url: https://codereview.webrtc.org/2740633003 > Cr-Commit-Position: refs/heads/master@{#17128} > Committed: https://chromium.googlesource.com/external/webrtc/+/822638b48111800434d7d4be6fef2f27c4e6e451 TBR=pthatcher@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2742743002 Cr-Commit-Position: refs/heads/master@{#17130} Committed: https://chromium.googlesource.com/external/webrtc/+/d6652076011363ab329d5cc4643619e4728303c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -0 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/base/cryptstring.h View 1 chunk +167 lines, -0 lines 0 comments Download
A webrtc/base/cryptstring.cc View 1 chunk +75 lines, -0 lines 0 comments Download
M webrtc/base/socketadapters.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nisse-webrtc
Created Revert of Delete cryptstring.h and cryptstring.cc.
3 years, 9 months ago (2017-03-09 08:35:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2742743002/1
3 years, 9 months ago (2017-03-09 08:35:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/d6652076011363ab329d5cc4643619e4728303c7
3 years, 9 months ago (2017-03-09 08:36:08 UTC) #6
nisse-webrtc
3 years, 9 months ago (2017-03-10 08:27:30 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2745523004/ by nisse@webrtc.org.

The reason for reverting is: CryptString usage is now deleted in Chrome, see cl
https://codereview.chromium.org/2738973004/.

Powered by Google App Engine
This is Rietveld 408576698