Chromium Code Reviews

Issue 2742603003: Reland of Add Metal video view in AppRTCMobile and metal availability macro. (Closed)

Created:
3 years, 9 months ago by kthelgason
Modified:
3 years, 9 months ago
Reviewers:
magjed_webrtc, tkchin_webrtc, daniela-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add Metal video view in AppRTCMobile and metal availability macro. (patchset #1 id:1 of https://codereview.webrtc.org/2739793003/ ) Reason for revert: Fixing rendering issues in AppRTCMobile Original issue's description: > Revert of Add Metal video view in AppRTCMobile and metal availability macro. (patchset #5 id:80001 of https://codereview.webrtc.org/2722583002/ ) > > Reason for revert: > Breaks AppRTCMobile > > Original issue's description: > > Add Metal video view in AppRTCMobile and Metal availability macro. > > > > - The RTC_SUPPORTS_METAL macro allows consumers to gracefully handle compilation for different archs that are not supporting Metal. > > > > BUG=webrtc:7079 > > > > Review-Url: https://codereview.webrtc.org/2722583002 > > Cr-Commit-Position: refs/heads/master@{#17004} > > Committed: https://chromium.googlesource.com/external/webrtc/+/154a7bb877abefada22afe28b0a755cf621e8d9e > > TBR=magjed@webrtc.org,tkchin@webrtc.org,denicija@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7079 > > Review-Url: https://codereview.webrtc.org/2739793003 > Cr-Commit-Position: refs/heads/master@{#17119} > Committed: https://chromium.googlesource.com/external/webrtc/+/cbbd8c76e8a8a1cf3f1193ea50980bc9d858458d TBR=magjed@webrtc.org,tkchin@webrtc.org,denicija@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2742603003 Cr-Commit-Position: refs/heads/master@{#17139} Committed: https://chromium.googlesource.com/external/webrtc/+/a2fb30c8cb29eec755fe931db7bf5aecf0d8dbbf

Patch Set 1 #

Patch Set 2 : Don't render without a texture #

Unified diffs Side-by-side diffs Stats (+34 lines, -14 lines)
M webrtc/examples/objc/AppRTCMobile/ios/ARDVideoCallView.h View 2 chunks +3 lines, -3 lines 0 comments
M webrtc/examples/objc/AppRTCMobile/ios/ARDVideoCallView.m View 2 chunks +13 lines, -2 lines 0 comments
M webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLNV12Renderer.mm View 3 chunks +8 lines, -6 lines 0 comments
M webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLVideoView.m View 1 chunk +2 lines, -2 lines 0 comments
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMTLVideoView.h View 2 chunks +8 lines, -1 line 0 comments

Messages

Total messages: 13 (8 generated)
kthelgason
Created Reland of Add Metal video view in AppRTCMobile and metal availability macro.
3 years, 9 months ago (2017-03-09 09:35:04 UTC) #1
kthelgason
Magnus, please take a look when you can.
3 years, 9 months ago (2017-03-09 09:43:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2742603003/150001
3 years, 9 months ago (2017-03-09 11:34:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:150001) as https://chromium.googlesource.com/external/webrtc/+/a2fb30c8cb29eec755fe931db7bf5aecf0d8dbbf
3 years, 9 months ago (2017-03-09 11:34:31 UTC) #12
magjed_webrtc
3 years, 9 months ago (2017-03-09 12:37:26 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine