Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2739793003: Revert of Add Metal video view in AppRTCMobile and metal availability macro. (Closed)

Created:
3 years, 9 months ago by kthelgason
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add Metal video view in AppRTCMobile and metal availability macro. (patchset #5 id:80001 of https://codereview.webrtc.org/2722583002/ ) Reason for revert: Breaks AppRTCMobile Original issue's description: > Add Metal video view in AppRTCMobile and Metal availability macro. > > - The RTC_SUPPORTS_METAL macro allows consumers to gracefully handle compilation for different archs that are not supporting Metal. > > BUG=webrtc:7079 > > Review-Url: https://codereview.webrtc.org/2722583002 > Cr-Commit-Position: refs/heads/master@{#17004} > Committed: https://chromium.googlesource.com/external/webrtc/+/154a7bb877abefada22afe28b0a755cf621e8d9e TBR=magjed@webrtc.org,tkchin@webrtc.org,denicija@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2739793003 Cr-Commit-Position: refs/heads/master@{#17119} Committed: https://chromium.googlesource.com/external/webrtc/+/cbbd8c76e8a8a1cf3f1193ea50980bc9d858458d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -26 lines) Patch
M webrtc/examples/objc/AppRTCMobile/ios/ARDVideoCallView.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/examples/objc/AppRTCMobile/ios/ARDVideoCallView.m View 2 chunks +2 lines, -13 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLVideoView.m View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMTLVideoView.h View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kthelgason
Created Revert of Add Metal video view in AppRTCMobile and metal availability macro.
3 years, 9 months ago (2017-03-08 13:51:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2739793003/1
3 years, 9 months ago (2017-03-08 13:51:59 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/builds/2308)
3 years, 9 months ago (2017-03-08 13:57:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2739793003/1
3 years, 9 months ago (2017-03-08 14:35:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/cbbd8c76e8a8a1cf3f1193ea50980bc9d858458d
3 years, 9 months ago (2017-03-08 14:55:07 UTC) #10
kthelgason
3 years, 9 months ago (2017-03-09 09:35:04 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2742603003/ by kthelgason@webrtc.org.

The reason for reverting is: Fixing rendering issues in AppRTCMobile.

Powered by Google App Engine
This is Rietveld 408576698