Remove ReceiveCodec() getters from VideoCodingModule.

Remove ReceiveCodec() getters from VideoCodingModule.

The getters are not used and the implementation cannot be guaranteed
to return a correct value except when called synchronously from
the decoding thread while decoding.

The methods as is imply that the implementation needs to offer some
sort of synchronization, and that's not desirable.

BUG=webrtc:7328
R=stefan@webrtc.org

Review-Url: https://codereview.webrtc.org/2741853008 .
Cr-Commit-Position: refs/heads/master@{#17233}
Committed: https://chromium.googlesource.com/external/webrtc/+/275e2099abe0aea4db7b89f1abeae264574e5afa

[tommi, 2017-03-11 15:39:49]

Description was changed from

==========
Remove ReceiveCodec() getters from VideoCodingModule.

The getters are not used and the implementation cannot be guaranteed
to return a correct value except when called synchronously from
the decoding thread while decoding.

The methods as is imply that the implementation needs to offer some
sort of synchonization, and that's not desireable.

BUG=none
==========

to

==========
Remove ReceiveCodec() getters from VideoCodingModule.

The getters are not used and the implementation cannot be guaranteed
to return a correct value except when called synchronously from
the decoding thread while decoding.

The methods as is imply that the implementation needs to offer some
sort of synchronization, and that's not desirable.

BUG=none
==========

[tommi, 2017-03-11 15:41:18]

tommi@webrtc.org changed reviewers:
+ stefan@webrtc.org

[tommi, 2017-03-11 15:41:24]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 15:41:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[tommi, 2017-03-11 15:54:31]

Description was changed from

==========
Remove ReceiveCodec() getters from VideoCodingModule.

The getters are not used and the implementation cannot be guaranteed
to return a correct value except when called synchronously from
the decoding thread while decoding.

The methods as is imply that the implementation needs to offer some
sort of synchronization, and that's not desirable.

BUG=none
==========

to

==========
Remove ReceiveCodec() getters from VideoCodingModule.

The getters are not used and the implementation cannot be guaranteed
to return a correct value except when called synchronously from
the decoding thread while decoding.

The methods as is imply that the implementation needs to offer some
sort of synchronization, and that's not desirable.

BUG=webrtc:7328
==========

[commit-bot: I haz the power, 2017-03-11 15:59:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 15:59:45]

Dry run: This issue passed the CQ dry run.

[tommi, 2017-03-14 13:31:06]

On 2017/03/11 15:41:18, tommi (webrtc) wrote:

ping

[stefan-webrtc, 2017-03-14 16:46:04]

lgtm

[tommi, 2017-03-14 17:23:21]

The CQ bit was checked by tommi@webrtc.org

[commit-bot: I haz the power, 2017-03-14 17:23:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-14 17:25:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 17:25:02]

Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/18364)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/22628)
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/22966)

[tommi, 2017-03-14 18:25:48]

Rebase

[tommi, 2017-03-14 18:27:24]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2017-03-14 18:27:25]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2741853008/#ps40001 (title:
"Rebase")

[commit-bot: I haz the power, 2017-03-14 18:27:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[tommi, 2017-03-14 18:55:25]

Description was changed from

==========
Remove ReceiveCodec() getters from VideoCodingModule.

The getters are not used and the implementation cannot be guaranteed
to return a correct value except when called synchronously from
the decoding thread while decoding.

The methods as is imply that the implementation needs to offer some
sort of synchronization, and that's not desirable.

BUG=webrtc:7328
==========

to

==========
Remove ReceiveCodec() getters from VideoCodingModule.

The getters are not used and the implementation cannot be guaranteed
to return a correct value except when called synchronously from
the decoding thread while decoding.

The methods as is imply that the implementation needs to offer some
sort of synchronization, and that's not desirable.

BUG=webrtc:7328
R=stefan@webrtc.org

Review-Url: https://codereview.webrtc.org/2741853008 .
Cr-Commit-Position: refs/heads/master@{#17233}
Committed:
https://chromium.googlesource.com/external/webrtc/+/275e2099abe0aea4db7b89f1a...
==========

[tommi, 2017-03-14 18:55:26]

Committed patchset #3 (id:40001) manually as
275e2099abe0aea4db7b89f1abeae264574e5afa (presubmit successful).