Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: webrtc/modules/video_coding/video_receiver.cc

Issue 2741853008: Remove ReceiveCodec() getters from VideoCodingModule. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_coding/video_coding_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/video_receiver.cc
diff --git a/webrtc/modules/video_coding/video_receiver.cc b/webrtc/modules/video_coding/video_receiver.cc
index 5bd08a129fbc86d2fb6bc1d54eff8428686faff7..6a4819eb1db0cf1f1cbfa820f372c24ff2097739 100644
--- a/webrtc/modules/video_coding/video_receiver.cc
+++ b/webrtc/modules/video_coding/video_receiver.cc
@@ -369,26 +369,6 @@ int32_t VideoReceiver::RegisterReceiveCodec(const VideoCodec* receiveCodec,
return 0;
}
-// Get current received codec
-// TODO(tommi): See if there are any actual callers to this method.
-// Neither me nor Stefan could find callers. If we can remove it, threading
-// will be simpler.
-int32_t VideoReceiver::ReceiveCodec(VideoCodec* currentReceiveCodec) const {
- rtc::CritScope cs(&receive_crit_);
- if (currentReceiveCodec == nullptr) {
- return VCM_PARAMETER_ERROR;
- }
- return _codecDataBase.ReceiveCodec(currentReceiveCodec) ? 0 : -1;
-}
-
-// Get current received codec
-// TODO(tommi): See if there are any actual callers to this method.
-// If not, it will make threading simpler.
-VideoCodecType VideoReceiver::ReceiveCodec() const {
- rtc::CritScope cs(&receive_crit_);
- return _codecDataBase.ReceiveCodec();
-}
-
// Incoming packet from network parsed and ready for decode, non blocking.
int32_t VideoReceiver::IncomingPacket(const uint8_t* incomingPayload,
size_t payloadLength,
« no previous file with comments | « webrtc/modules/video_coding/video_coding_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698