Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2739143002: Revert of Enable cpplint and fix cpplint errors in webrtc/*audio (Closed)

Created:
3 years, 9 months ago by oprypin_webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, sdk-team_agora.io, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Enable cpplint and fix cpplint errors in webrtc/*audio (patchset #4 id:180001 of https://codereview.webrtc.org/2683033004/ ) Reason for revert: The API change in audio/utility/audio_frame_operations.h caused breakage. Need to keep backward-compatible API. Original issue's description: > Enable cpplint and fix cpplint errors in webrtc/*audio > > Change usage accordingly throughout the codebase > > BUG=webrtc:5268 > > TESTED=Fixed issues reported by: > find webrtc/*audio -type f -name *.cc -o -name *.h | xargs cpplint.py > > Review-Url: https://codereview.webrtc.org/2683033004 > Cr-Commit-Position: refs/heads/master@{#17133} > Committed: https://chromium.googlesource.com/external/webrtc/+/aebe55ca6c2f725c81031722badb297a2fb1d331 TBR=henrika@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5268 Review-Url: https://codereview.webrtc.org/2739143002 Cr-Commit-Position: refs/heads/master@{#17138} Committed: https://chromium.googlesource.com/external/webrtc/+/e47c1d3ca172e5ea84e59c1e88dbe25664664e54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1093 lines, -1037 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/audio/audio_transport_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/utility/audio_frame_operations.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/audio/utility/audio_frame_operations.cc View 1 chunk +19 lines, -19 lines 0 comments Download
M webrtc/audio/utility/audio_frame_operations_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M webrtc/common_audio/audio_converter.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/audio_converter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/common_audio/blocker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/channel_buffer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/include/audio_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_audio/lapped_transform.h View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/common_audio/real_fourier.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/resampler/include/resampler.h View 2 chunks +60 lines, -57 lines 0 comments Download
M webrtc/common_audio/resampler/push_resampler.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/resampler/push_sinc_resampler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_audio/resampler/resampler.cc View 1 chunk +902 lines, -846 lines 0 comments Download
M webrtc/common_audio/resampler/sinc_resampler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_audio/ring_buffer_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/common_audio/signal_processing/include/signal_processing_library.h View 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/common_audio/signal_processing/include/spl_inl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/common_audio/signal_processing/include/spl_inl_armv7.h View 4 chunks +7 lines, -5 lines 0 comments Download
M webrtc/common_audio/signal_processing/include/spl_inl_mips.h View 13 chunks +27 lines, -15 lines 0 comments Download
M webrtc/common_audio/signal_processing/real_fft_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/common_audio/signal_processing/resample_by_2_internal.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/signal_processing/signal_processing_unittest.cc View 4 chunks +8 lines, -10 lines 0 comments Download
M webrtc/common_audio/vad/vad_core.h View 3 chunks +5 lines, -2 lines 0 comments Download
M webrtc/common_audio/vad/vad_core_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/common_audio/vad/vad_filterbank_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/common_audio/vad/vad_gmm_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/common_audio/vad/vad_sp_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/common_audio/vad/vad_unittest.h View 3 chunks +5 lines, -7 lines 0 comments Download
M webrtc/common_audio/vad/vad_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
oprypin_webrtc
Created Revert of Enable cpplint and fix cpplint errors in webrtc/*audio
3 years, 9 months ago (2017-03-09 10:43:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2739143002/1
3 years, 9 months ago (2017-03-09 10:43:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/e47c1d3ca172e5ea84e59c1e88dbe25664664e54
3 years, 9 months ago (2017-03-09 10:43:35 UTC) #6
oprypin_webrtc
3 years, 9 months ago (2017-03-09 10:52:45 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2739073003/ by oprypin@webrtc.org.

The reason for reverting is: Can reland it if backwards compatible API is kept..

Powered by Google App Engine
This is Rietveld 408576698