Enable cpplint and fix cpplint errors in webrtc/*audio

Enable cpplint and fix cpplint errors in webrtc/*audio

Change usage accordingly throughout the codebase

BUG=webrtc:5268
TESTED=Fixed issues reported by:
find webrtc/*audio -type f -name *.cc -o -name *.h | xargs cpplint.py

Review-Url: https://codereview.webrtc.org/2683033004
Cr-Commit-Position: refs/heads/master@{#17133}
Committed: https://chromium.googlesource.com/external/webrtc/+/aebe55ca6c2f725c81031722badb297a2fb1d331

[oprypin_webrtc, 2017-02-09 14:27:40]

The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 14:27:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-09 14:43:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 14:43:53]

Dry run: Try jobs failed on following builders:
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/17314)

[oprypin_webrtc, 2017-02-11 21:51:08]

The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 21:51:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-11 21:55:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 21:55:03]

Dry run: Try jobs failed on following builders:
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/22652)

[oprypin_webrtc, 2017-02-11 22:01:37]

The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 22:01:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-11 23:16:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 23:16:47]

Dry run: This issue passed the CQ dry run.

[oprypin_webrtc, 2017-02-11 23:22:11]

The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 23:22:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-11 23:25:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 23:25:06]

Dry run: Try jobs failed on following builders:
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/17400)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/17221)

[oprypin_webrtc, 2017-02-12 21:33:02]

Patchset #4 (id:60001) has been deleted

[oprypin_webrtc, 2017-02-12 21:33:17]

The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 21:33:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-12 22:24:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-12 22:24:59]

Dry run: This issue passed the CQ dry run.

[oprypin_webrtc, 2017-03-06 17:35:45]

Patchset #1 (id:1) has been deleted

[oprypin_webrtc, 2017-03-06 17:35:55]

Patchset #1 (id:20001) has been deleted

[oprypin_webrtc, 2017-03-06 17:36:03]

Patchset #1 (id:40001) has been deleted

[oprypin_webrtc, 2017-03-06 17:36:14]

Patchset #1 (id:80001) has been deleted

[oprypin_webrtc, 2017-03-06 17:36:24]

The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 17:36:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-06 17:40:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 17:40:04]

Dry run: Try jobs failed on following builders:
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/21962)

[oprypin_webrtc, 2017-03-06 17:44:37]

The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 17:44:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-06 18:05:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 18:05:05]

Dry run: This issue passed the CQ dry run.

[oprypin_webrtc, 2017-03-07 09:02:08]

The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 09:02:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[oprypin_webrtc, 2017-03-07 09:13:09]

Description was changed from

==========
Enable cpplint and fix cpplint errors in webrtc/*audio

Change usage accordingly throughout the codebase

BUG=webrtc:5268

TESTED=Fixed issues reported by:
find webrtc/*audio -type f -name *.cc -o -name *.h | xargs cpplint.py
==========

to

==========
Enable cpplint and fix cpplint errors in webrtc/*audio

Change usage accordingly throughout the codebase

BUG=webrtc:5268

TESTED=Fixed issues reported by:
find webrtc/*audio -type f -name *.cc -o -name *.h | xargs cpplint.py
==========

[oprypin_webrtc, 2017-03-07 09:13:09]

oprypin@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, henrika@webrtc.org

[commit-bot: I haz the power, 2017-03-07 09:24:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 09:24:29]

Dry run: This issue passed the CQ dry run.

[henrika_webrtc, 2017-03-08 12:27:53]

LGTM for webrtc/audio and webrtc/voice_engine

[kwiberg-webrtc, 2017-03-08 12:55:13]

https://codereview.webrtc.org/2683033004/diff/140001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/2683033004/diff/140001/PRESUBMIT.py#newcode33
PRESUBMIT.py:33: 'webrtc/video',
Drive-by comment: Any chance we could use a blacklist instead, so that the
default is to be scanned?

(Not saying it should be done in this CL, just that it would probably be a good
idea.)

[oprypin_webrtc, 2017-03-08 13:22:03]

https://codereview.webrtc.org/2683033004/diff/140001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/2683033004/diff/140001/PRESUBMIT.py#newcode33
PRESUBMIT.py:33: 'webrtc/video',
On 2017/03/08 12:55:12, kwiberg-webrtc wrote:
> Drive-by comment: Any chance we could use a blacklist instead, so that the
> default is to be scanned?
> 
> (Not saying it should be done in this CL, just that it would probably be a
good
> idea.)

You could bring this up in the parent issue
https://bugs.chromium.org/p/webrtc/issues/detail?id=5149
As it progresses, it will make more and more sense to do this.

[kwiberg-webrtc, 2017-03-08 13:25:00]

kwiberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2017-03-08 13:25:01]

https://codereview.webrtc.org/2683033004/diff/140001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/2683033004/diff/140001/PRESUBMIT.py#newcode33
PRESUBMIT.py:33: 'webrtc/video',
On 2017/03/08 13:22:03, oprypin_webrtc wrote:
> On 2017/03/08 12:55:12, kwiberg-webrtc wrote:
> > Drive-by comment: Any chance we could use a blacklist instead, so that the
> > default is to be scanned?
> > 
> > (Not saying it should be done in this CL, just that it would probably be a
> good
> > idea.)
> 
> You could bring this up in the parent issue
> https://bugs.chromium.org/p/webrtc/issues/detail?id=5149
> As it progresses, it will make more and more sense to do this.

Done. Thanks!

[hlundin-webrtc, 2017-03-08 14:34:12]

webrtc/common_audio: lgtm

[oprypin_webrtc, 2017-03-08 15:42:05]

The CQ bit was checked by oprypin@webrtc.org

[commit-bot: I haz the power, 2017-03-08 15:42:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[oprypin_webrtc, 2017-03-08 15:42:24]

The CQ bit was unchecked by oprypin@webrtc.org

[oprypin_webrtc, 2017-03-09 08:13:32]

Patchset #4 (id:160001) has been deleted

[oprypin_webrtc, 2017-03-09 08:14:29]

The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 08:14:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-09 08:35:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 08:35:43]

Dry run: This issue passed the CQ dry run.

[oprypin_webrtc, 2017-03-09 08:42:33]

I rebased. Is this good to land?

[henrika_webrtc, 2017-03-09 09:00:39]

You don't need more OK from us based on a rebase. Unless it was not trivial.

[oprypin_webrtc, 2017-03-09 09:02:42]

The CQ bit was checked by oprypin@webrtc.org

[oprypin_webrtc, 2017-03-09 09:02:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org, henrika@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2683033004/#ps180001 (title:
"Rebase")

[commit-bot: I haz the power, 2017-03-09 09:02:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-09 09:05:34]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1489050162466890,
"parent_rev": "3e530d20cad074d2220b66cbe858d8d255811dfb", "commit_rev":
"aebe55ca6c2f725c81031722badb297a2fb1d331"}

[commit-bot: I haz the power, 2017-03-09 09:05:37]

Description was changed from

==========
Enable cpplint and fix cpplint errors in webrtc/*audio

Change usage accordingly throughout the codebase

BUG=webrtc:5268

TESTED=Fixed issues reported by:
find webrtc/*audio -type f -name *.cc -o -name *.h | xargs cpplint.py
==========

to

==========
Enable cpplint and fix cpplint errors in webrtc/*audio

Change usage accordingly throughout the codebase

BUG=webrtc:5268

TESTED=Fixed issues reported by:
find webrtc/*audio -type f -name *.cc -o -name *.h | xargs cpplint.py

Review-Url: https://codereview.webrtc.org/2683033004
Cr-Commit-Position: refs/heads/master@{#17133}
Committed:
https://chromium.googlesource.com/external/webrtc/+/aebe55ca6c2f725c81031722b...
==========

[commit-bot: I haz the power, 2017-03-09 09:05:38]

Committed patchset #4 (id:180001) as
https://chromium.googlesource.com/external/webrtc/+/aebe55ca6c2f725c81031722b...

[oprypin_webrtc, 2017-03-09 10:43:19]

A revert of this CL (patchset #4 id:180001) has been created in
https://codereview.webrtc.org/2739143002/ by oprypin@webrtc.org.

The reason for reverting is: The API change in
audio/utility/audio_frame_operations.h caused breakage. Need to keep
backward-compatible API..