Remove VoEHardware interface usage.

Remove VoEHardware interface usage.

BUG=webrtc:4690
Review-Url: https://codereview.webrtc.org/2737633002
Cr-Commit-Position: refs/heads/master@{#17248}
Committed: https://chromium.googlesource.com/external/webrtc/+/9a5f0322278ee8b5b660392ea0c26776ae807818

[the sun, 2017-03-10 14:18:47]

Description was changed from

==========
Remove VoEHardware interface.

BUG=webrtc:4690
==========

to

==========
Remove VoEHardware interface usage.

BUG=webrtc:4690
==========

[the sun, 2017-03-10 14:18:48]

solenberg@webrtc.org changed reviewers:
+ henrika@webrtc.org

[the sun, 2017-03-10 14:23:41]

The CQ bit was checked by solenberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 14:23:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-10 14:28:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 14:28:14]

Dry run: Try jobs failed on following builders:
  win_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/17134)
  win_x64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/23560)

[henrika_webrtc, 2017-03-13 11:15:55]

Looks good but I have some questions.

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/adm_h...
File webrtc/media/engine/adm_helpers.cc (right):

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/adm_h...
webrtc/media/engine/adm_helpers.cc:39: bool was_recording = adm->Recording();
const would not hurt

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/adm_h...
File webrtc/media/engine/adm_helpers.h (right):

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/adm_h...
webrtc/media/engine/adm_helpers.h:22: void SetRecordingDevice(AudioDeviceModule*
adm);
It is refcounted but I know that you know...
Guess raw pointer is OK.

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine_unittest.cc:77: void
AdmSetupExpectations(webrtc::test::MockAudioDeviceModule* adm) {
These changes does not correlate 100% with the removal of the VoEHardware. Care
to elaborate on how you came up with the new (extended) expectations?

[the sun, 2017-03-15 12:47:57]

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/adm_h...
File webrtc/media/engine/adm_helpers.cc (right):

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/adm_h...
webrtc/media/engine/adm_helpers.cc:39: bool was_recording = adm->Recording();
On 2017/03/13 11:15:55, henrika_webrtc wrote:
> const would not hurt

Done.

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/adm_h...
File webrtc/media/engine/adm_helpers.h (right):

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/adm_h...
webrtc/media/engine/adm_helpers.h:22: void SetRecordingDevice(AudioDeviceModule*
adm);
On 2017/03/13 11:15:55, henrika_webrtc wrote:
> It is refcounted but I know that you know...
> Guess raw pointer is OK.

In this case, the raw pointer is used to signal we're not actually passing
ownership, only "lending" the ADM for the duration of the call.

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine_unittest.cc:77: void
AdmSetupExpectations(webrtc::test::MockAudioDeviceModule* adm) {
On 2017/03/13 11:15:55, henrika_webrtc wrote:
> These changes does not correlate 100% with the removal of the VoEHardware.
Care
> to elaborate on how you came up with the new (extended) expectations?

Certainly!

The previous calls to SetRecordingDevice(), SetPlayoutDevice() never touched the
ADM - they went through VoEHardware, which was provided by
FakeWebRtcVoiceEngine. Now they go directly to the ADM.

[the sun, 2017-03-15 12:48:01]

The CQ bit was checked by solenberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 12:48:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[henrika_webrtc, 2017-03-15 12:50:19]

LGTM

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/adm_h...
File webrtc/media/engine/adm_helpers.cc (right):

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/adm_h...
webrtc/media/engine/adm_helpers.cc:39: bool was_recording = adm->Recording();
On 2017/03/15 12:47:57, the sun wrote:
> On 2017/03/13 11:15:55, henrika_webrtc wrote:
> > const would not hurt
> 
> Done.

Acknowledged.

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/adm_h...
File webrtc/media/engine/adm_helpers.h (right):

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/adm_h...
webrtc/media/engine/adm_helpers.h:22: void SetRecordingDevice(AudioDeviceModule*
adm);
On 2017/03/15 12:47:57, the sun wrote:
> On 2017/03/13 11:15:55, henrika_webrtc wrote:
> > It is refcounted but I know that you know...
> > Guess raw pointer is OK.
> 
> In this case, the raw pointer is used to signal we're not actually passing
> ownership, only "lending" the ADM for the duration of the call.

Acknowledged.

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/2737633002/diff/80001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine_unittest.cc:77: void
AdmSetupExpectations(webrtc::test::MockAudioDeviceModule* adm) {
On 2017/03/15 12:47:57, the sun wrote:
> On 2017/03/13 11:15:55, henrika_webrtc wrote:
> > These changes does not correlate 100% with the removal of the VoEHardware.
> Care
> > to elaborate on how you came up with the new (extended) expectations?
> 
> Certainly!
> 
> The previous calls to SetRecordingDevice(), SetPlayoutDevice() never touched
the
> ADM - they went through VoEHardware, which was provided by
> FakeWebRtcVoiceEngine. Now they go directly to the ADM.

Acknowledged.

[commit-bot: I haz the power, 2017-03-15 13:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 13:10:55]

Dry run: This issue passed the CQ dry run.

[the sun, 2017-03-15 13:11:59]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2017-03-15 13:12:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-15 13:14:13]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489583519641940,
"parent_rev": "e49fede158e9a8c9e8aeef06093a8d591331e9f7", "commit_rev":
"9a5f0322278ee8b5b660392ea0c26776ae807818"}

[commit-bot: I haz the power, 2017-03-15 13:14:16]

Description was changed from

==========
Remove VoEHardware interface usage.

BUG=webrtc:4690
==========

to

==========
Remove VoEHardware interface usage.

BUG=webrtc:4690

Review-Url: https://codereview.webrtc.org/2737633002
Cr-Commit-Position: refs/heads/master@{#17248}
Committed:
https://chromium.googlesource.com/external/webrtc/+/9a5f0322278ee8b5b660392ea...
==========

[commit-bot: I haz the power, 2017-03-15 13:14:17]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/9a5f0322278ee8b5b660392ea...