Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2753753004: Remove VoEHardware interface. (Closed)

Created:
3 years, 9 months ago by the sun
Modified:
3 years, 9 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, AleBzk, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VoEHardware interface. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/2753753004 Cr-Commit-Position: refs/heads/master@{#17255} Committed: https://chromium.googlesource.com/external/webrtc/+/5b3e49a29e442bb6b5cb4a8a1d9496566887e212

Patch Set 1 #

Patch Set 2 : repoint base #

Patch Set 3 : remove a little more #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -919 lines) Patch
M webrtc/voice_engine/BUILD.gn View 4 chunks +0 lines, -11 lines 0 comments Download
D webrtc/voice_engine/include/voe_hardware.h View 1 chunk +0 lines, -109 lines 0 comments Download
M webrtc/voice_engine/shared_data.h View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M webrtc/voice_engine/shared_data.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_initialization_fixture.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_initialization_fixture.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D webrtc/voice_engine/test/auto_test/standard/hardware_before_initializing_test.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D webrtc/voice_engine/test/auto_test/standard/hardware_before_streaming_test.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D webrtc/voice_engine/test/auto_test/standard/hardware_test.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_test_defines.h View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/voice_engine/voe_base_impl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/voe_codec_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/voice_engine/voe_hardware_impl.h View 1 chunk +0 lines, -65 lines 0 comments Download
D webrtc/voice_engine/voe_hardware_impl.cc View 1 chunk +0 lines, -502 lines 0 comments Download
M webrtc/voice_engine/voice_engine_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
the sun
3 years, 9 months ago (2017-03-15 13:53:15 UTC) #2
henrika_webrtc
Great. LGTM
3 years, 9 months ago (2017-03-15 13:57:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2753753004/60001
3 years, 9 months ago (2017-03-15 15:05:57 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 15:08:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/5b3e49a29e442bb6b5cb4a8a1...

Powered by Google App Engine
This is Rietveld 408576698