Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2735733002: Reland of Add QP for FFmpeg H264 decoder. (Closed)

Created:
3 years, 9 months ago by sakal
Modified:
3 years, 9 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add QP for FFmpeg H264 decoder. (patchset #1 id:1 of https://codereview.webrtc.org/2726973003/ ) Reason for revert: The issue is now hopefully fixed. Original issue's description: > Revert of Add QP for FFmpeg H264 decoder. (patchset #4 id:200001 of https://codereview.webrtc.org/2649133007/ ) > > Reason for revert: > Let's revert this while we investigate a problem in H264 bitstream parser. > > Original issue's description: > > Add QP for FFmpeg H264 decoder. > > > > BUG=webrtc:6541 > > > > Review-Url: https://codereview.webrtc.org/2649133007 > > Cr-Commit-Position: refs/heads/master@{#16942} > > Committed: https://chromium.googlesource.com/external/webrtc/+/879f4f6c3148fda61e988cd085e0520dc393a2af > > TBR=sprang@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6541, chromium:697795 > > Review-Url: https://codereview.webrtc.org/2726973003 > Cr-Commit-Position: refs/heads/master@{#16974} > Committed: https://chromium.googlesource.com/external/webrtc/+/4c6df8893eb4aeea1fddb2b369bb9e4743a933f6 TBR=sprang@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6541, chromium:697795 Review-Url: https://codereview.webrtc.org/2735733002 Cr-Commit-Position: refs/heads/master@{#17061} Committed: https://chromium.googlesource.com/external/webrtc/+/b8102e06347fbf3f19234c9e6449c8059b908e03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -154 lines) Patch
M webrtc/modules/video_coding/BUILD.gn View 3 chunks +6 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc View 2 chunks +12 lines, -7 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/test/h264_impl_unittest.cc View 1 chunk +76 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/test/video_codec_test.h View 1 chunk +101 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/test/video_codec_test.cc View 1 chunk +115 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/test/vp9_impl_unittest.cc View 1 chunk +11 lines, -147 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
sakal
Created Reland of Add QP for FFmpeg H264 decoder.
3 years, 9 months ago (2017-03-06 10:55:27 UTC) #1
sakal
This CL hopefully fixed the issue: https://codereview.webrtc.org/2732623002/
3 years, 9 months ago (2017-03-06 10:56:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2735733002/1
3 years, 9 months ago (2017-03-06 11:50:44 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 11:53:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b8102e06347fbf3f19234c9e6...

Powered by Google App Engine
This is Rietveld 408576698