Add QP for FFmpeg H264 decoder.

Add QP for FFmpeg H264 decoder.

BUG=webrtc:6541
Review-Url: https://codereview.webrtc.org/2649133007
Cr-Commit-Position: refs/heads/master@{#16942}
Committed: https://chromium.googlesource.com/external/webrtc/+/879f4f6c3148fda61e988cd085e0520dc393a2af

[sakal, 2017-02-27 14:33:56]

Patchset #2 (id:20001) has been deleted

[sakal, 2017-02-27 14:34:01]

Patchset #1 (id:1) has been deleted

[sakal, 2017-02-27 14:35:10]

Description was changed from

==========
Add QP for ffmpeg H264 decoder.

BUG=webrtc:6541
==========

to

==========
Add QP for FFmpeg H264 decoder.

BUG=webrtc:6541
==========

[sakal, 2017-02-27 14:38:09]

sakal@webrtc.org changed reviewers:
+ sprang@webrtc.org

[sakal, 2017-02-27 14:38:10]

PTAL

I looked into getting the QP directly from FFmpeg but it seems quite hard to do.
This should be fine for now.

[sakal, 2017-02-27 14:39:00]

Patchset #1 (id:40001) has been deleted

[sprang_webrtc, 2017-02-28 09:01:52]

looks good
any chance you could add a unit test as well?

https://codereview.webrtc.org/2649133007/diff/60001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc (right):

https://codereview.webrtc.org/2649133007/diff/60001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc:366: qp =
rtc::Optional<uint8_t>(qp_int);
nit: qp.emplace(qp_int);

[sakal, 2017-02-28 14:11:24]

Patchset #3 (id:100001) has been deleted

[sakal, 2017-02-28 14:12:29]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 14:12:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2017-02-28 14:17:21]

Patchset #3 (id:120001) has been deleted

[sakal, 2017-02-28 14:17:27]

Patchset #3 (id:140001) has been deleted

[sakal, 2017-02-28 14:18:07]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 14:18:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-28 14:20:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 14:20:24]

Dry run: Try jobs failed on following builders:
  linux_arm on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm/builds/6288)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)

[sakal, 2017-02-28 14:35:48]

Patchset #3 (id:160001) has been deleted

[sakal, 2017-03-01 13:26:48]

https://codereview.webrtc.org/2649133007/diff/60001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc (right):

https://codereview.webrtc.org/2649133007/diff/60001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc:366: qp =
rtc::Optional<uint8_t>(qp_int);
On 2017/02/28 09:01:52, språng wrote:
> nit: qp.emplace(qp_int);

Done.

[sakal, 2017-03-01 13:27:27]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 13:27:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-01 13:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 13:46:23]

Dry run: This issue passed the CQ dry run.

[sprang_webrtc, 2017-03-01 14:13:15]

lgtm with question

https://codereview.webrtc.org/2649133007/diff/200001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc (left):

https://codereview.webrtc.org/2649133007/diff/200001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc:391: }
Why remove check for error return code?

[sakal, 2017-03-01 14:15:10]

https://codereview.webrtc.org/2649133007/diff/200001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc (left):

https://codereview.webrtc.org/2649133007/diff/200001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc:391: }
On 2017/03/01 14:13:15, språng wrote:
> Why remove check for error return code?

We decided to remove the return value from the new callback interface because
the callback always returned success anyway.

[sakal, 2017-03-01 14:17:03]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2017-03-01 14:17:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-01 14:19:10]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1488377823469560,
"parent_rev": "013ea23290f09957e99b7f40df559089bd7bc201", "commit_rev":
"879f4f6c3148fda61e988cd085e0520dc393a2af"}

[commit-bot: I haz the power, 2017-03-01 14:19:13]

Description was changed from

==========
Add QP for FFmpeg H264 decoder.

BUG=webrtc:6541
==========

to

==========
Add QP for FFmpeg H264 decoder.

BUG=webrtc:6541

Review-Url: https://codereview.webrtc.org/2649133007
Cr-Commit-Position: refs/heads/master@{#16942}
Committed:
https://chromium.googlesource.com/external/webrtc/+/879f4f6c3148fda61e988cd08...
==========

[commit-bot: I haz the power, 2017-03-01 14:19:15]

Committed patchset #4 (id:200001) as
https://chromium.googlesource.com/external/webrtc/+/879f4f6c3148fda61e988cd08...

[sprang_webrtc, 2017-03-01 14:38:24]

thanks for doing the test refactoring

https://codereview.webrtc.org/2649133007/diff/200001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc (left):

https://codereview.webrtc.org/2649133007/diff/200001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc:391: }
On 2017/03/01 14:15:10, sakal wrote:
> On 2017/03/01 14:13:15, språng wrote:
> > Why remove check for error return code?
> 
> We decided to remove the return value from the new callback interface because
> the callback always returned success anyway.

Acknowledged.

[sakal, 2017-03-02 14:55:44]

A revert of this CL (patchset #4 id:200001) has been created in
https://codereview.webrtc.org/2726973003/ by sakal@webrtc.org.

The reason for reverting is: Let's revert this while we investigate a problem in
H264 bitstream parser..