Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2735613002: Reland: Improve testing of SRTP external auth code paths. (Closed)

Created:
3 years, 9 months ago by joachim
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland: Improve testing of SRTP external auth code paths. This CL is a reland of https://codereview.webrtc.org/2722423003 which got reverted due to compile errors when rolling into Chromium. Original CL description: Improve testing of SRTP external auth code paths. Previously code behind ENABLE_EXTERNAL_AUTH was only compiled with Chromium but developed in WebRTC, which made testing rather complicated. This caused some trouble in the past (e.g. https://crbug.com/628400#c1) This CL helps in that the external auth code is now compiled with WebRTC and the srtpfilter integration gets tested. BUG=chromium:628400 Review-Url: https://codereview.webrtc.org/2735613002 Cr-Commit-Position: refs/heads/master@{#17052} Committed: https://chromium.googlesource.com/external/webrtc/+/dfcab728b21cec2994131a449c6c1e38018c264a

Patch Set 1 #

Patch Set 2 : Fix compile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -141 lines) Patch
M webrtc/pc/BUILD.gn View 2 chunks +2 lines, -6 lines 0 comments Download
M webrtc/pc/channel.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/pc/externalhmac.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/pc/externalhmac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/pc/srtpfilter.h View 4 chunks +20 lines, -8 lines 0 comments Download
M webrtc/pc/srtpfilter.cc View 9 chunks +25 lines, -18 lines 0 comments Download
M webrtc/pc/srtpfilter_unittest.cc View 5 chunks +95 lines, -105 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
joachim
Ptal
3 years, 9 months ago (2017-03-05 11:07:24 UTC) #2
Taylor Brandstetter
lgtm
3 years, 9 months ago (2017-03-06 00:05:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2735613002/20001
3 years, 9 months ago (2017-03-06 07:51:20 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 08:14:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/dfcab728b21cec2994131a449...

Powered by Google App Engine
This is Rietveld 408576698