Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2729373002: Remove HAVE_SRTP define and unmaintained code. (Closed)

Created:
3 years, 9 months ago by joachim
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove HAVE_SRTP define and unmaintained code. It was defined unconditionally and the code for non-HAVE_SRTP was unmaintained and failed to compile. BUG=webrtc:7294 Review-Url: https://codereview.webrtc.org/2729373002 Cr-Commit-Position: refs/heads/master@{#17074} Committed: https://chromium.googlesource.com/external/webrtc/+/eaa9c1db73133d771ea7a9b7ceb39b4286df0e78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -120 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/pc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/externalhmac.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/pc/externalhmac.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/pc/mediasession.cc View 7 chunks +0 lines, -10 lines 0 comments Download
M webrtc/pc/mediasession_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/pc/srtpfilter.cc View 4 chunks +0 lines, -93 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
joachim
Ptal
3 years, 9 months ago (2017-03-06 09:13:42 UTC) #2
Taylor Brandstetter
lgtm
3 years, 9 months ago (2017-03-06 18:33:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2729373002/1
3 years, 9 months ago (2017-03-06 19:00:43 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 19:32:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/eaa9c1db73133d771ea7a9b7c...

Powered by Google App Engine
This is Rietveld 408576698