Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2735583002: Revert of Enable GN check for webrtc/{ortc,p2p} (Closed)

Created:
3 years, 9 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Enable GN check for webrtc/{ortc,p2p} (patchset #4 id:60001 of https://codereview.webrtc.org/2714263004/ ) Reason for revert: Fails compile in Chromium for NaCl: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/9320/ http://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/22215 http://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/14501 Original issue's description: > Enable GN check for webrtc/{ortc,p2p} > > Introduce new target //webrtc/p2p:rtc_p2p_test_utils to host > test-related utilities. > Previously uncovered header "base/fakecandidatepair.h" is now also in a target. > > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2714263004 > Cr-Commit-Position: refs/heads/master@{#17036} > Committed: https://chromium.googlesource.com/external/webrtc/+/c9515b6ce642875c4994deb25a5bb0132a958848 TBR=deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2735583002 Cr-Commit-Position: refs/heads/master@{#17038} Committed: https://chromium.googlesource.com/external/webrtc/+/98e153101276c7ca341082ca7bf4b10a9e23f2fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -55 lines) Patch
M .gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/ortc/BUILD.gn View 2 chunks +0 lines, -15 lines 0 comments Download
M webrtc/p2p/BUILD.gn View 7 chunks +9 lines, -38 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kjellander_webrtc
Created Revert of Enable GN check for webrtc/{ortc,p2p}
3 years, 9 months ago (2017-03-04 23:08:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2735583002/1
3 years, 9 months ago (2017-03-04 23:08:39 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-04 23:08:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/98e153101276c7ca341082ca7...

Powered by Google App Engine
This is Rietveld 408576698