 Chromium Code Reviews
 Chromium Code Reviews Issue 
            2735583002:
    Revert of Enable GN check for webrtc/{ortc,p2p}  (Closed)
    
  
    Issue 
            2735583002:
    Revert of Enable GN check for webrtc/{ortc,p2p}  (Closed) 
  | DescriptionRevert of Enable GN check for webrtc/{ortc,p2p} (patchset #4 id:60001 of https://codereview.webrtc.org/2714263004/ )
Reason for revert:
Fails compile in Chromium for NaCl:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/9320/
 http://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/22215
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/14501
Original issue's description:
> Enable GN check for webrtc/{ortc,p2p}
> 
> Introduce new target //webrtc/p2p:rtc_p2p_test_utils to host 
> test-related utilities.
> Previously uncovered header "base/fakecandidatepair.h" is now also in a target.
> 
> BUG=webrtc:6828
> 
> Review-Url: https://codereview.webrtc.org/2714263004
> Cr-Commit-Position: refs/heads/master@{#17036}
> Committed: https://chromium.googlesource.com/external/webrtc/+/c9515b6ce642875c4994deb25a5bb0132a958848
TBR=deadbeef@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828
Review-Url: https://codereview.webrtc.org/2735583002
Cr-Commit-Position: refs/heads/master@{#17038}
Committed: https://chromium.googlesource.com/external/webrtc/+/98e153101276c7ca341082ca7bf4b10a9e23f2fc
   Patch Set 1 #
 Messages
    Total messages: 6 (3 generated)
     | |||||||||||||||||||||||||||||||||||||