Enable GN check for webrtc/{ortc,p2p}

Enable GN check for webrtc/{ortc,p2p}

Introduce new target //webrtc/p2p:rtc_p2p_test_utils to host 
test-related utilities.
Previously uncovered header "base/fakecandidatepair.h" is now also in a target.

BUG=webrtc:6828
Review-Url: https://codereview.webrtc.org/2714263004
Cr-Commit-Position: refs/heads/master@{#17036}
Committed: https://chromium.googlesource.com/external/webrtc/+/c9515b6ce642875c4994deb25a5bb0132a958848

[kjellander_webrtc, 2017-03-02 08:09:14]

kjellander@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2017-03-02 23:52:35]

https://codereview.webrtc.org/2714263004/diff/20001/webrtc/p2p/BUILD.gn
File webrtc/p2p/BUILD.gn (right):

https://codereview.webrtc.org/2714263004/diff/20001/webrtc/p2p/BUILD.gn#newco...
webrtc/p2p/BUILD.gn:234: ":rtc_p2p_unittests",
Similar to the other CL, this shouldn't include rtc_p2p_unittests.

[kjellander_webrtc, 2017-03-03 03:37:28]

Description was changed from

==========
Enable GN check in webrtc/p2p

BUG=webrtc:6828
==========

to

==========
Enable GN check for webrtc/{ortc,p2p}

Introduce new target //webrtc/p2p:rtc_p2p_test_utils to host 
test-related utilities.
Previously uncovered header "base/fakecandidatepair.h" is now also in a target.

BUG=webrtc:6828
==========

[kjellander_webrtc, 2017-03-03 04:12:56]

I did the refactoring and included the separate ortc CL into this. Looks green
now.

https://codereview.webrtc.org/2714263004/diff/20001/webrtc/p2p/BUILD.gn
File webrtc/p2p/BUILD.gn (right):

https://codereview.webrtc.org/2714263004/diff/20001/webrtc/p2p/BUILD.gn#newco...
webrtc/p2p/BUILD.gn:234: ":rtc_p2p_unittests",
On 2017/03/02 23:52:35, Taylor Brandstetter wrote:
> Similar to the other CL, this shouldn't include rtc_p2p_unittests.

You're right. I refactored it and merged the ortc CL into this one.

[Taylor Brandstetter, 2017-03-03 05:44:52]

lgtm after moving mockicetransport.h

https://codereview.webrtc.org/2714263004/diff/40001/webrtc/p2p/BUILD.gn
File webrtc/p2p/BUILD.gn (left):

https://codereview.webrtc.org/2714263004/diff/40001/webrtc/p2p/BUILD.gn#oldco...
webrtc/p2p/BUILD.gn:154: "base/mockicetransport.h",
mockicetransport should go there too.

[kjellander_webrtc, 2017-03-03 05:49:53]

https://codereview.webrtc.org/2714263004/diff/40001/webrtc/p2p/BUILD.gn
File webrtc/p2p/BUILD.gn (left):

https://codereview.webrtc.org/2714263004/diff/40001/webrtc/p2p/BUILD.gn#oldco...
webrtc/p2p/BUILD.gn:154: "base/mockicetransport.h",
On 2017/03/03 05:44:52, Taylor Brandstetter wrote:
> mockicetransport should go there too.

Actually it was already in :rtc_p2p_test_utils (and the test*. files).
I just forgot to remove them from this target. Done now.

[kjellander_webrtc, 2017-03-03 06:15:32]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2017-03-03 06:15:32]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2714263004/#ps60001 (title:
"Rebased and removed duplicated headers")

[commit-bot: I haz the power, 2017-03-03 06:15:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-03 06:24:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 06:24:48]

Try jobs failed on following builders:
  linux_more_configs on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_more_configs/buil...)

[kjellander_webrtc, 2017-03-04 21:27:33]

On 2017/03/03 06:24:48, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_more_configs on master.tryserver.webrtc (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.webrtc/builders/linux_more_configs/buil...)

^^ was caused by my erroneous CL for webrtc/examples. All trybots are passing
now.

[kjellander_webrtc, 2017-03-04 21:28:30]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2017-03-04 21:28:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kjellander_webrtc, 2017-03-04 21:28:49]

The CQ bit was unchecked by kjellander@webrtc.org

[kjellander_webrtc, 2017-03-04 21:29:01]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2017-03-04 21:29:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-04 21:47:45]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488662941638780,
"parent_rev": "a80e4f6958e4b5b45a4e7f4b33d4d214ce24c11e", "commit_rev":
"c9515b6ce642875c4994deb25a5bb0132a958848"}

[commit-bot: I haz the power, 2017-03-04 21:47:49]

Description was changed from

==========
Enable GN check for webrtc/{ortc,p2p}

Introduce new target //webrtc/p2p:rtc_p2p_test_utils to host 
test-related utilities.
Previously uncovered header "base/fakecandidatepair.h" is now also in a target.

BUG=webrtc:6828
==========

to

==========
Enable GN check for webrtc/{ortc,p2p}

Introduce new target //webrtc/p2p:rtc_p2p_test_utils to host 
test-related utilities.
Previously uncovered header "base/fakecandidatepair.h" is now also in a target.

BUG=webrtc:6828

Review-Url: https://codereview.webrtc.org/2714263004
Cr-Commit-Position: refs/heads/master@{#17036}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c9515b6ce642875c4994deb25...
==========

[commit-bot: I haz the power, 2017-03-04 21:47:51]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/c9515b6ce642875c4994deb25...

[kjellander_webrtc, 2017-03-04 23:08:34]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.webrtc.org/2735583002/ by kjellander@webrtc.org.

The reason for reverting is: Fails compile in Chromium for NaCl:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build...

http://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds...
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/buil...

.