Enable GN check for webrtc/{ortc,p2p}

webrtc/p2p/BUILD.gn

 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../webrtc.gni")
 
@@ skipping 65 matching lines @@
     "base/udptransport.h",
     "client/basicportallocator.cc",
     "client/basicportallocator.h",
     "client/socketmonitor.cc",
     "client/socketmonitor.h",
   ]
 
   defines = []
 
   deps = [
+    "../api:libjingle_peerconnection_api",
+    "../api:ortc_api",
     "../base:rtc_base",
+    "../system_wrappers",
   ]
 
   if (rtc_build_expat) {
     deps += [ "//third_party/expat" ]
     public_deps = [
       "//third_party/expat",
     ]
   }
 
   public_configs = [ ":rtc_p2p_inherited_config" ]
@@ skipping 41 matching lines @@
     public_deps += [ "//third_party/libquic" ]
   }
 }
 
 if (rtc_include_tests) {
   rtc_source_set("rtc_p2p_unittests") {
     testonly = true
     sources = [
       "base/asyncstuntcpsocket_unittest.cc",
       "base/dtlstransportchannel_unittest.cc",
-      "base/fakedtlstransport.h",
-      "base/fakeicetransport.h",
-      "base/fakepackettransport.h",
-      "base/fakeportallocator.h",
-      "base/faketransportcontroller.h",
       "base/jseptransport_unittest.cc",
       "base/mockicetransport.h",

[Taylor Brandstetter, 2017/03/03 05:44:52]

mockicetransport should go there too.

[kjellander_webrtc, 2017/03/03 05:49:53]

Actually it was already in :rtc_p2p_test_utils (and the test*. files).
I just forgot to remove them from this target. Done now.

       "base/p2ptransportchannel_unittest.cc",
       "base/port_unittest.cc",
       "base/portallocator_unittest.cc",
       "base/pseudotcp_unittest.cc",
       "base/relayport_unittest.cc",
       "base/relayserver_unittest.cc",
       "base/stun_unittest.cc",
       "base/stunport_unittest.cc",
       "base/stunrequest_unittest.cc",
       "base/stunserver_unittest.cc",
@@ skipping 12 matching lines @@
       sources += [
         "quic/quicconnectionhelper_unittest.cc",
         "quic/quicsession_unittest.cc",
         "quic/quictransport_unittest.cc",
         "quic/quictransportchannel_unittest.cc",
         "quic/reliablequicstream_unittest.cc",
       ]
     }
     deps = [
       ":rtc_p2p",
+      ":rtc_p2p_test_utils",
       "../api:fakemetricsobserver",
+      "../api:ortc_api",
+      "../base:rtc_base",
+      "../base:rtc_base_approved",
+      "../base:rtc_base_tests_utils",
+      "../test:test_support",
       "//testing/gmock",
       "//testing/gtest",
     ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
     defines = [ "GTEST_RELATIVE_PATH" ]
   }
+
+  rtc_source_set("rtc_p2p_test_utils") {
+    testonly = true
+    sources = [
+      "base/fakecandidatepair.h",
+      "base/fakedtlstransport.h",
+      "base/fakeicetransport.h",
+      "base/fakepackettransport.h",
+      "base/fakeportallocator.h",
+      "base/faketransportcontroller.h",
+      "base/mockicetransport.h",
+      "base/testrelayserver.h",
+      "base/teststunserver.h",
+      "base/testturnserver.h",
+    ]
+    deps = [
+      ":rtc_p2p",
+      "../api:ortc_api",
+      "../base:rtc_base",
+      "../base:rtc_base_approved",
+      "../base:rtc_base_tests_utils",
+      "../test:test_support",
+    ]
+  }
 }
 
 rtc_static_library("libstunprober") {
   sources = [
     "stunprober/stunprober.cc",
   ]
 
   if (!build_with_chromium && is_clang) {
     # Suppress warnings from Chrome's Clang plugins.
     # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   deps = [
+    ":rtc_p2p",
     "..:webrtc_common",
     "../base:rtc_base",
   ]
 }
 
 if (rtc_include_tests) {
   rtc_source_set("libstunprober_unittests") {
     testonly = true
     sources = [
       "stunprober/stunprober_unittest.cc",
     ]
     deps = [
       ":libstunprober",
+      ":rtc_p2p",
+      ":rtc_p2p_test_utils",
+      "../base:rtc_base",
+      "../base:rtc_base_tests_utils",
       "//testing/gmock",
       "//testing/gtest",
     ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
     defines = [ "GTEST_RELATIVE_PATH" ]
   }
 }