Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 2733673002: Reland "Enable GN check for webrtc/examples" (Closed)

Created:
3 years, 9 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Enable GN check for webrtc/examples" This is a reland of https://codereview.webrtc.org/2714343002 with the errors related to inclusions of test targets in webrtc/api resolved. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2733673002 Cr-Commit-Position: refs/heads/master@{#17053} Committed: https://chromium.googlesource.com/external/webrtc/+/1993b1de1f27e0892cd5fd6921b6f761b0af1166

Patch Set 1 #

Patch Set 2 : Move out libjingle_peerconnection_test_api #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -27 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/BUILD.gn View 1 2 chunks +15 lines, -16 lines 1 comment Download
M webrtc/examples/BUILD.gn View 23 chunks +49 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kjellander_webrtc
Don't mind the Chromium trybots, they're failing because there's the .gn change (a file Chromium ...
3 years, 9 months ago (2017-03-04 06:22:22 UTC) #2
kjellander_webrtc
https://codereview.webrtc.org/2733673002/diff/20001/webrtc/api/BUILD.gn File webrtc/api/BUILD.gn (left): https://codereview.webrtc.org/2733673002/diff/20001/webrtc/api/BUILD.gn#oldcode204 webrtc/api/BUILD.gn:204: "//webrtc/test:test_support", Turns out test_support was unused, making it possible ...
3 years, 9 months ago (2017-03-04 06:22:58 UTC) #3
perkj_webrtc
lgtm
3 years, 9 months ago (2017-03-06 08:17:32 UTC) #4
perkj_webrtc
lgtm
3 years, 9 months ago (2017-03-06 08:19:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2733673002/20001
3 years, 9 months ago (2017-03-06 08:27:07 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 08:29:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/1993b1de1f27e0892cd5fd692...

Powered by Google App Engine
This is Rietveld 408576698