Chromium Code Reviews

Issue 2714343002: Enable GN check for webrtc/examples (Closed)

Created:
3 years, 10 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable GN check for webrtc/examples BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2714343002 Cr-Commit-Position: refs/heads/master@{#16987} Committed: https://chromium.googlesource.com/external/webrtc/+/81db74a3841b42c0a84c2f35b91eab66fd3f4e79

Patch Set 1 #

Patch Set 2 : Fixes for iOS #

Patch Set 3 : Win and Linux fixes #

Patch Set 4 : More Linux fixes #

Patch Set 5 : Fix bug for gtk #

Patch Set 6 : Another win fix #

Patch Set 7 : Rebased #

Unified diffs Side-by-side diffs Stats (+50 lines, -11 lines)
M .gn View 1 chunk +1 line, -0 lines 0 comments
M webrtc/examples/BUILD.gn View 23 chunks +49 lines, -11 lines 0 comments

Messages

Total messages: 18 (9 generated)
perkj_webrtc
On 2017/02/26 06:58:35, kjellander_webrtc wrote: > mailto:kjellander@webrtc.org changed reviewers: > + mailto:perkj@webrtc.org looks like some ...
3 years, 9 months ago (2017-02-27 08:37:52 UTC) #4
kjellander_webrtc
Now it seems fixed
3 years, 9 months ago (2017-03-01 15:04:49 UTC) #5
perkj_webrtc
lgtm
3 years, 9 months ago (2017-03-02 09:01:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2714343002/100001
3 years, 9 months ago (2017-03-02 17:44:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14388)
3 years, 9 months ago (2017-03-02 17:48:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2714343002/120001
3 years, 9 months ago (2017-03-03 05:26:58 UTC) #13
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/external/webrtc/+/81db74a3841b42c0a84c2f35b91eab66fd3f4e79
3 years, 9 months ago (2017-03-03 05:29:36 UTC) #16
kjellander_webrtc
On 2017/03/03 05:29:36, commit-bot: I haz the power wrote: > Committed patchset #7 (id:120001) as ...
3 years, 9 months ago (2017-03-03 06:19:29 UTC) #17
kjellander_webrtc
3 years, 9 months ago (2017-03-03 06:27:10 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.webrtc.org/2727253003/ by kjellander@webrtc.org.

The reason for reverting is: I wasn't able to resolve it with that CL so I'll
have to revert this by now.

Will have another look at this when time permits..

Powered by Google App Engine