Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2725053008: GN: Include webrtc/api targets even if rtc_include_tests=false (Closed)

Created:
3 years, 9 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Include webrtc/api targets even if rtc_include_tests=false The main purpose with the rtc_include_tests GN variable is to avoid generating and compiling all the test targets. Some of our examples have dependencies on the test headers in API, so therefore this change is relaxing that condition. BUG=webrtc:6828 NOTRY=True TBR=ehmaldonado@webrtc.org, Review-Url: https://codereview.webrtc.org/2725053008 Cr-Commit-Position: refs/heads/master@{#16989} Committed: https://chromium.googlesource.com/external/webrtc/+/a769ceba656eff1d12df82ef3058306cf948b215

Patch Set 1 #

Patch Set 2 : Put the test code in a condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M webrtc/api/BUILD.gn View 1 1 chunk +41 lines, -41 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
kjellander_webrtc
This fixes the breakage in https://build.chromium.org/p/client.webrtc/builders/Linux%20%28more%20configs%29/builds/1898 that happened because of https://codereview.webrtc.org/2714343002/
3 years, 9 months ago (2017-03-03 06:19:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2725053008/20001
3 years, 9 months ago (2017-03-03 06:23:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/a769ceba656eff1d12df82ef3058306cf948b215
3 years, 9 months ago (2017-03-03 06:25:07 UTC) #9
kjellander_webrtc
3 years, 9 months ago (2017-03-03 06:26:08 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2728073002/ by kjellander@webrtc.org.

The reason for reverting is: Fails Chromium builds: 
b/c/b/linux/src/buildtools/linux64/gn gen //out/Release --check
  -> returned 1
ERROR at //third_party/webrtc/api/BUILD.gn:186:5: Can't load input file.
    "//webrtc/test:test_support",
    ^-------------------------.

Powered by Google App Engine
This is Rietveld 408576698