Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2731703004: Revert of Setting is_component_build to false by default (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Setting is_component_build to false by default (patchset #5 id:80001 of https://codereview.webrtc.org/2728643003/ ) Reason for revert: Breaks chrome rolls Original issue's description: > Setting is_component_build to false by default > > Webrtc does not support component builds so we want to override > the chromium default value (which can be true on debug builds if the > os is different from iOS). > > Please note that the user can set this value to true in two ways: > > - using --args (e.g.: gn gen out/default --args='is_component_build=true' > - changing the value in the args.gn file > > But in both cases the value will be ignored because we don't use the > 'component' template but we rely directly on 'rtc_static_library' and > 'rtc_shared_library'. > > BUG=webrtc:6975 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2728643003 > Cr-Commit-Position: refs/heads/master@{#17020} > Committed: https://chromium.googlesource.com/external/webrtc/+/2cb3944ba7e4467601ebd94888e1811a6d77be49 TBR=kjellander@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6975 Review-Url: https://codereview.webrtc.org/2731703004 Cr-Commit-Position: refs/heads/master@{#17025} Committed: https://chromium.googlesource.com/external/webrtc/+/2d9e7685a59c05e62c23d7125064c8e5c1f88edb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -34 lines) Patch
M .gn View 1 chunk +0 lines, -11 lines 0 comments Download
M tools-webrtc/mb/mb_config.pyl View 4 chunks +16 lines, -8 lines 0 comments Download
M webrtc/webrtc.gni View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tommi
Created Revert of Setting is_component_build to false by default
3 years, 9 months ago (2017-03-04 00:14:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2731703004/1
3 years, 9 months ago (2017-03-04 00:14:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/2d9e7685a59c05e62c23d7125064c8e5c1f88edb
3 years, 9 months ago (2017-03-04 00:15:06 UTC) #6
mbonadei
3 years, 9 months ago (2017-03-04 03:25:27 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2729243003/ by mbonadei@webrtc.org.

The reason for reverting is: Trying to fix this skipping the check if we are
building webrtc within chromium..

Powered by Google App Engine
This is Rietveld 408576698