Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: webrtc/webrtc.gni

Issue 2731703004: Revert of Setting is_component_build to false by default (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools-webrtc/mb/mb_config.pyl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/webrtc.gni
diff --git a/webrtc/webrtc.gni b/webrtc/webrtc.gni
index 48fc1541f212e51562d12516cb6fa3c5722a8cf8..96975fae9a4227568632a0fc50932d487cd134ac 100644
--- a/webrtc/webrtc.gni
+++ b/webrtc/webrtc.gni
@@ -13,21 +13,6 @@
import("//build/config/ui.gni")
import("//build_overrides/build.gni")
import("//testing/test.gni")
-
-if (is_component_build) {
- print("The Gn argument `is_component_build` is currently " +
- "ignored for WebRTC builds.")
- print("Component builds are supported by Chromium and the argument " +
- "`is_component_build` makes it possible to create shared libraries " +
- "instead of static libraries.")
- print("If an app depends on WebRTC it makes sense to just depend on the " +
- "WebRTC static library, so there is no difference between " +
- "`is_component_build=true` and `is_component_build=false`.")
- print(
- "More info about component builds at: " + "https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md")
- assert(!is_component_build, "Component builds are not supported in WebRTC.")
-}
-
if (is_ios) {
import("//build/config/ios/rules.gni")
}
« no previous file with comments | « tools-webrtc/mb/mb_config.pyl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698