Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Issue 2730673004: Reland of Fix flaky EndToEndTest.TransportSeqNumOnAudioAndVideo (Closed)

Created:
3 years, 9 months ago by danilchap
Modified:
3 years, 9 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Fix flaky EndToEndTest.TransportSeqNumOnAudioAndVideo (patchset #1 id:1 of https://codereview.webrtc.org/2730893002/ ) Reason for revert: Fixing race and relanding Original issue's description: > Revert of Fix flaky EndToEndTest.TransportSeqNumOnAudioAndVideo (patchset #2 id:20001 of https://codereview.webrtc.org/2728103002/ ) > > Reason for revert: > Fails on tsan > http://build.chromium.org/p/client.webrtc/builders/Linux%20Tsan%20v2/builds/10235 > > Original issue's description: > > Fix flaky EndToEndTest.TransportSeqNumOnAudioAndVideo > > Add extra checks to it to simplify diagnostic should it fail again. > > > > BUG=webrtc:7292 > > > > Review-Url: https://codereview.webrtc.org/2728103002 > > Cr-Commit-Position: refs/heads/master@{#16999} > > Committed: https://chromium.googlesource.com/external/webrtc/+/bcb6004a9d53615a6428e070cbc6d52a2d8e833b > > TBR=asapersson@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7292 > > Review-Url: https://codereview.webrtc.org/2730893002 > Cr-Commit-Position: refs/heads/master@{#17000} > Committed: https://chromium.googlesource.com/external/webrtc/+/9a59473f2c403827a3560944c7ffe76d37ab77b9 TBR=asapersson@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7292 Review-Url: https://codereview.webrtc.org/2730673004 Cr-Commit-Position: refs/heads/master@{#17006} Committed: https://chromium.googlesource.com/external/webrtc/+/4336d73bd3c8df53ec396e9600463c8e162e20b1

Patch Set 1 #

Patch Set 2 : Move final expect past RunBaseTest to avoid race #

Patch Set 3 : spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M webrtc/video/end_to_end_tests.cc View 1 2 4 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
danilchap
Created Reland of Fix flaky EndToEndTest.TransportSeqNumOnAudioAndVideo
3 years, 9 months ago (2017-03-03 13:34:37 UTC) #1
danilchap
This time checked locally with tsan too, ptal
3 years, 9 months ago (2017-03-03 13:46:53 UTC) #2
åsapersson
lgtm
3 years, 9 months ago (2017-03-03 13:51:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2730673004/60001
3 years, 9 months ago (2017-03-03 14:21:47 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 14:22:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/4336d73bd3c8df53ec396e960...

Powered by Google App Engine
This is Rietveld 408576698