Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2728103002: Fix flaky EndToEndTest.TransportSeqNumOnAudioAndVideo (Closed)

Created:
3 years, 9 months ago by danilchap
Modified:
3 years, 9 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix flaky EndToEndTest.TransportSeqNumOnAudioAndVideo Add extra checks to it to simplify diagnostic should it fail again. BUG=webrtc:7292 Review-Url: https://codereview.webrtc.org/2728103002 Cr-Commit-Position: refs/heads/master@{#16999} Committed: https://chromium.googlesource.com/external/webrtc/+/bcb6004a9d53615a6428e070cbc6d52a2d8e833b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Name the kMinPacketsToWaitFor constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M webrtc/video/end_to_end_tests.cc View 1 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
danilchap
3 years, 9 months ago (2017-03-03 10:45:37 UTC) #2
åsapersson
lgtm https://codereview.webrtc.org/2728103002/diff/1/webrtc/video/end_to_end_tests.cc File webrtc/video/end_to_end_tests.cc (right): https://codereview.webrtc.org/2728103002/diff/1/webrtc/video/end_to_end_tests.cc#newcode4066 webrtc/video/end_to_end_tests.cc:4066: received_packet_ids_.size() >= 50) { maybe add a constant ...
3 years, 9 months ago (2017-03-03 11:16:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2728103002/20001
3 years, 9 months ago (2017-03-03 12:14:11 UTC) #10
danilchap
https://codereview.webrtc.org/2728103002/diff/1/webrtc/video/end_to_end_tests.cc File webrtc/video/end_to_end_tests.cc (right): https://codereview.webrtc.org/2728103002/diff/1/webrtc/video/end_to_end_tests.cc#newcode4066 webrtc/video/end_to_end_tests.cc:4066: received_packet_ids_.size() >= 50) { On 2017/03/03 11:16:19, åsapersson wrote: ...
3 years, 9 months ago (2017-03-03 12:14:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/bcb6004a9d53615a6428e070cbc6d52a2d8e833b
3 years, 9 months ago (2017-03-03 12:38:15 UTC) #14
danilchap
3 years, 9 months ago (2017-03-03 13:04:36 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2730893002/ by danilchap@webrtc.org.

The reason for reverting is: Fails on tsan
http://build.chromium.org/p/client.webrtc/builders/Linux%20Tsan%20v2/builds/1....

Powered by Google App Engine
This is Rietveld 408576698