Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2729623005: Revert of fixed VP8 simulcast to not decode non-selected streams (Closed)

Created:
3 years, 9 months ago by ilnik
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of fixed VP8 simulcast to not decode non-selected streams (patchset #5 id:80001 of https://codereview.webrtc.org/2728553003/ ) Reason for revert: Causes regression in VP8 simulcast metrics (receive time, encoded frame size, etc) as two excluded streams' decoders request keyframes periodically, which affects metrics of a selected stream. Original issue's description: > In full-stack tests: fixed VP8 simulcast to not decode non-selected streams. > > BUG=webrtc:7095 > > Review-Url: https://codereview.webrtc.org/2728553003 > Cr-Commit-Position: refs/heads/master@{#16948} > Committed: https://chromium.googlesource.com/external/webrtc/+/8dccd67520ac40fb9c644f3ecc9cecd160002883 TBR=sprang@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7095 Review-Url: https://codereview.webrtc.org/2729623005 Cr-Commit-Position: refs/heads/master@{#16967} Committed: https://chromium.googlesource.com/external/webrtc/+/68af10de7ffc7ccf9b1ee12bc163acb814a626d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
M webrtc/test/layer_filtering_transport.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/test/layer_filtering_transport.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 3 chunks +13 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ilnik
Created Revert of fixed VP8 simulcast to not decode non-selected streams
3 years, 9 months ago (2017-03-02 12:59:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2729623005/1
3 years, 9 months ago (2017-03-02 12:59:27 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 12:59:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/68af10de7ffc7ccf9b1ee12bc...

Powered by Google App Engine
This is Rietveld 408576698