fixed VP8 simulcast to not decode non-selected streams

In full-stack tests: fixed VP8 simulcast to not decode non-selected streams.

BUG=webrtc:7095
Review-Url: https://codereview.webrtc.org/2728553003
Cr-Commit-Position: refs/heads/master@{#16948}
Committed: https://chromium.googlesource.com/external/webrtc/+/8dccd67520ac40fb9c644f3ecc9cecd160002883

[ilnik, 2017-03-01 11:31:19]

Description was changed from

==========
fixed VP8 simulcast to not decode non-selected streams

BUG=webrtc:7095
==========

to

==========
In full-stack tests: fixed VP8 simulcast to not decode non-selected streams.

BUG=webrtc:7095
==========

[ilnik, 2017-03-01 11:31:36]

ilnik@webrtc.org changed reviewers:
+ sprang@webrtc.org

[sprang_webrtc, 2017-03-01 12:30:38]

https://codereview.webrtc.org/2728553003/diff/40001/webrtc/test/layer_filteri...
File webrtc/test/layer_filtering_transport.h (right):

https://codereview.webrtc.org/2728553003/diff/40001/webrtc/test/layer_filteri...
webrtc/test/layer_filtering_transport.h:31: const std::vector<uint32_t>
&allowed_ssrcs_);
Do we want to whitelist or blacklist?
I'm thinking that if we add new features in the future the may use a new
separate ssrc (not sure how flexfec works for instance) we would have to figure
that out and add a them to the whitelist. So maybe it's safer to just blacklist
the ssrcs of the streams we _don't_ want to receive?

https://codereview.webrtc.org/2728553003/diff/40001/webrtc/test/layer_filteri...
webrtc/test/layer_filtering_transport.h:45: std::vector<uint32_t>
allowed_ssrcs_;
May want to go for a set instead of a vector. Probably not faster, but cleaner
code.

[ilnik, 2017-03-01 12:54:43]

https://codereview.webrtc.org/2728553003/diff/40001/webrtc/test/layer_filteri...
File webrtc/test/layer_filtering_transport.h (right):

https://codereview.webrtc.org/2728553003/diff/40001/webrtc/test/layer_filteri...
webrtc/test/layer_filtering_transport.h:31: const std::vector<uint32_t>
&allowed_ssrcs_);
On 2017/03/01 12:30:38, språng wrote:
> Do we want to whitelist or blacklist?
> I'm thinking that if we add new features in the future the may use a new
> separate ssrc (not sure how flexfec works for instance) we would have to
figure
> that out and add a them to the whitelist. So maybe it's safer to just
blacklist
> the ssrcs of the streams we _don't_ want to receive?

Absolutely, blacklist is better. Doing that.

https://codereview.webrtc.org/2728553003/diff/40001/webrtc/test/layer_filteri...
webrtc/test/layer_filtering_transport.h:45: std::vector<uint32_t>
allowed_ssrcs_;
On 2017/03/01 12:30:38, språng wrote:
> May want to go for a set instead of a vector. Probably not faster, but cleaner
> code.

Done.

[sprang_webrtc, 2017-03-01 14:06:06]

lgtm

[ilnik, 2017-03-01 14:06:23]

The CQ bit was checked by ilnik@webrtc.org

[commit-bot: I haz the power, 2017-03-01 14:06:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ilnik, 2017-03-01 14:11:20]

ilnik@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[commit-bot: I haz the power, 2017-03-01 14:11:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 14:11:24]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14327)

[kjellander_webrtc, 2017-03-01 15:07:22]

rs lgtm for webrtc/test

[ilnik, 2017-03-01 15:08:04]

The CQ bit was checked by ilnik@webrtc.org

[commit-bot: I haz the power, 2017-03-01 15:08:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-01 15:10:31]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488380884000910,
"parent_rev": "4cbe2862524d8e2cb31d0715eb1d26b378846417", "commit_rev":
"8dccd67520ac40fb9c644f3ecc9cecd160002883"}

[commit-bot: I haz the power, 2017-03-01 15:10:33]

Description was changed from

==========
In full-stack tests: fixed VP8 simulcast to not decode non-selected streams.

BUG=webrtc:7095
==========

to

==========
In full-stack tests: fixed VP8 simulcast to not decode non-selected streams.

BUG=webrtc:7095

Review-Url: https://codereview.webrtc.org/2728553003
Cr-Commit-Position: refs/heads/master@{#16948}
Committed:
https://chromium.googlesource.com/external/webrtc/+/8dccd67520ac40fb9c644f3ec...
==========

[commit-bot: I haz the power, 2017-03-01 15:10:34]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/8dccd67520ac40fb9c644f3ec...

[ilnik, 2017-03-02 12:59:19]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.webrtc.org/2729623005/ by ilnik@webrtc.org.

The reason for reverting is: Causes regression in VP8 simulcast metrics (receive
time, encoded frame size, etc) as two excluded streams' decoders request
keyframes periodically, which affects metrics of a selected stream..