Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2728073002: Revert of GN: Include webrtc/api targets even if rtc_include_tests=false (Closed)

Created:
3 years, 9 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of GN: Include webrtc/api targets even if rtc_include_tests=false (patchset #2 id:20001 of https://codereview.webrtc.org/2725053008/ ) Reason for revert: Fails Chromium builds: b/c/b/linux/src/buildtools/linux64/gn gen //out/Release --check -> returned 1 ERROR at //third_party/webrtc/api/BUILD.gn:186:5: Can't load input file. "//webrtc/test:test_support", ^------------------------- Original issue's description: > GN: Include webrtc/api targets even if rtc_include_tests=false > > The main purpose with the rtc_include_tests GN variable is to avoid > generating and compiling all the test targets. > Some of our examples have dependencies on the test headers in API, > so therefore this change is relaxing that condition. > > BUG=webrtc:6828 > NOTRY=True > TBR=ehmaldonado@webrtc.org, > > Review-Url: https://codereview.webrtc.org/2725053008 > Cr-Commit-Position: refs/heads/master@{#16989} > Committed: https://chromium.googlesource.com/external/webrtc/+/a769ceba656eff1d12df82ef3058306cf948b215 TBR=ehmaldonado@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2728073002 Cr-Commit-Position: refs/heads/master@{#16990} Committed: https://chromium.googlesource.com/external/webrtc/+/2f6af9ca7ad47537e8df8634cc9e23c0df860b4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -54 lines) Patch
M webrtc/api/BUILD.gn View 1 chunk +54 lines, -54 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kjellander_webrtc
Created Revert of GN: Include webrtc/api targets even if rtc_include_tests=false
3 years, 9 months ago (2017-03-03 06:26:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2728073002/1
3 years, 9 months ago (2017-03-03 06:26:18 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 06:26:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/2f6af9ca7ad47537e8df8634c...

Powered by Google App Engine
This is Rietveld 408576698