Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2727253003: Revert of Enable GN check for webrtc/examples (Closed)

Created:
3 years, 9 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Enable GN check for webrtc/examples (patchset #7 id:120001 of https://codereview.webrtc.org/2714343002/ ) Reason for revert: I wasn't able to resolve it with that CL so I'll have to revert this by now. Will have another look at this when time permits. Original issue's description: > Enable GN check for webrtc/examples > > BUG=webrtc:6828 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2714343002 > Cr-Commit-Position: refs/heads/master@{#16987} > Committed: https://chromium.googlesource.com/external/webrtc/+/81db74a3841b42c0a84c2f35b91eab66fd3f4e79 TBR=perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2727253003 Cr-Commit-Position: refs/heads/master@{#16991} Committed: https://chromium.googlesource.com/external/webrtc/+/eda3a9b58295f436665ac39a9f66864d01f7ab96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -51 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/examples/BUILD.gn View 23 chunks +12 lines, -50 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kjellander_webrtc
Created Revert of Enable GN check for webrtc/examples
3 years, 9 months ago (2017-03-03 06:27:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2727253003/1
3 years, 9 months ago (2017-03-03 06:27:18 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 06:27:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/eda3a9b58295f436665ac39a9...

Powered by Google App Engine
This is Rietveld 408576698