Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2723883004: Revert of H264BitstreamParser: Log nalu type when parsing slice type fails. (Closed)

Created:
3 years, 9 months ago by sakal
Modified:
3 years, 9 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, perkj_webrtc, kthelgason
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of H264BitstreamParser: Log nalu type when parsing slice type fails. (patchset #1 id:60001 of https://codereview.webrtc.org/2726833005/ ) Reason for revert: Investigation complete. Original issue's description: > H264BitstreamParser: Log nalu type when parsing slice type fails. > > Decreases all parsing failures to a warning because they are not > critical errors. This is a speculative commit to help diagnose > why bots are failing. > > BUG=chromium:697795 > TBR=stefan@webrtc.org > > Review-Url: https://codereview.webrtc.org/2726833005 > Cr-Commit-Position: refs/heads/master@{#16966} > Committed: https://chromium.googlesource.com/external/webrtc/+/6bce6ad4859725cfcf274f48de3fcac13e886cca TBR=stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:697795 Review-Url: https://codereview.webrtc.org/2723883004 Cr-Commit-Position: refs/heads/master@{#16972} Committed: https://chromium.googlesource.com/external/webrtc/+/cabea3dbf25d23347539ce22803aa17f701e07f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M webrtc/common_video/h264/h264_bitstream_parser.cc View 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sakal
Created Revert of H264BitstreamParser: Log nalu type when parsing slice type fails.
3 years, 9 months ago (2017-03-02 14:54:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2723883004/1
3 years, 9 months ago (2017-03-02 14:55:00 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 14:55:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/cabea3dbf25d23347539ce228...

Powered by Google App Engine
This is Rietveld 408576698