Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2726833005:
H264BitstreamParser: Log nalu type when parsing slice type fails. (Closed)
|
Created:
3 years, 9 months ago by sakal Modified:
3 years, 9 months ago Reviewers:
stefan-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, perkj_webrtc, kthelgason Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionH264BitstreamParser: Log nalu type when parsing slice type fails.
Decreases all parsing failures to a warning because they are not
critical errors. This is a speculative commit to help diagnose
why bots are failing.
BUG=chromium:697795
TBR=stefan@webrtc.org
Review-Url: https://codereview.webrtc.org/2726833005
Cr-Commit-Position: refs/heads/master@{#16966}
Committed: https://chromium.googlesource.com/external/webrtc/+/6bce6ad4859725cfcf274f48de3fcac13e886cca
Patch Set 1 : Change log. #
Messages
Total messages: 22 (15 generated)
Description was changed from ========== H264BitstreamParser: Remove logging from failing to parse a frame. Decreases all parsing failures to a warning because they are not critical errors. Removes logging from a single statement that is triggered by a test. BUG=chromium:697795 ========== to ========== H264BitstreamParser: Log nalu type when parsing slice type fails. Decreases all parsing failures to a warning because they are not critical errors. This is a speculative commit to help diagnose why bots are failing. BUG=chromium:697795 ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
sakal@webrtc.org changed reviewers: + stefan@webrtc.org
PTAL
sakal@webrtc.org changed reviewers: + henrika@webrtc.org - stefan@webrtc.org
I forgot Stefan is in US right now, henrika, can you PTAL?
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
I have exactly zero experience from any code related to video. If you feel it is a safe change, I suggest that you TBR Stefan instead. An OK from me would not provide any value. Sorry.
Description was changed from ========== H264BitstreamParser: Log nalu type when parsing slice type fails. Decreases all parsing failures to a warning because they are not critical errors. This is a speculative commit to help diagnose why bots are failing. BUG=chromium:697795 ========== to ========== H264BitstreamParser: Log nalu type when parsing slice type fails. Decreases all parsing failures to a warning because they are not critical errors. This is a speculative commit to help diagnose why bots are failing. BUG=chromium:697795 TBR=stefan@webrtc.org ==========
sakal@webrtc.org changed reviewers: + stefan@webrtc.org - henrika@webrtc.org
On 2017/03/02 12:07:29, henrika_webrtc wrote: > I have exactly zero experience from any code related to video. If you feel it is > a safe change, > I suggest that you TBR Stefan instead. An OK from me would not provide any > value. Sorry. Ok, let's do that instead. This should be safe it just changes the log message.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488457906368910,
"parent_rev": "fb4f8b6cb430678b0e5d99f222cb0878effefafc", "commit_rev":
"6bce6ad4859725cfcf274f48de3fcac13e886cca"}
Message was sent while issue was closed.
Description was changed from ========== H264BitstreamParser: Log nalu type when parsing slice type fails. Decreases all parsing failures to a warning because they are not critical errors. This is a speculative commit to help diagnose why bots are failing. BUG=chromium:697795 TBR=stefan@webrtc.org ========== to ========== H264BitstreamParser: Log nalu type when parsing slice type fails. Decreases all parsing failures to a warning because they are not critical errors. This is a speculative commit to help diagnose why bots are failing. BUG=chromium:697795 TBR=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/2726833005 Cr-Commit-Position: refs/heads/master@{#16966} Committed: https://chromium.googlesource.com/external/webrtc/+/6bce6ad4859725cfcf274f48d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as https://chromium.googlesource.com/external/webrtc/+/6bce6ad4859725cfcf274f48d...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:60001) has been created in https://codereview.webrtc.org/2723883004/ by sakal@webrtc.org. The reason for reverting is: Investigation complete.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
