Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2722633005: Move RTCOutboundRTPStreamStats.roundTripTime to inbound, don't collect. (Closed)

Created:
3 years, 9 months ago by hbos
Modified:
3 years, 9 months ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move RTCOutboundRTPStreamStats.roundTripTime to inbound, don't collect. The value is being moved: https://github.com/w3c/webrtc-stats/pull/167 Stop collecting this value. Our previous value was incorrect, our RTT value was a smoothed value based on STUN pings but the spec says it should be based on RTCP timestamps in RTCP Receiver Report (RR) on inbound streams with isRemote=true (not supported). Updated some bug references. BUG=webrtc:7065, webrtc:7066 Review-Url: https://codereview.webrtc.org/2722633005 Cr-Commit-Position: refs/heads/master@{#16931} Committed: https://chromium.googlesource.com/external/webrtc/+/a7a9be159df454db9d861b49b94b3d02a283eb1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -43 lines) Patch
M webrtc/api/stats/rtcstats_objects.h View 3 chunks +19 lines, -18 lines 0 comments Download
M webrtc/pc/rtcstats_integrationtest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/pc/rtcstatscollector.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/pc/rtcstatscollector_unittest.cc View 5 chunks +1 line, -16 lines 0 comments Download
M webrtc/stats/rtcstats_objects.cc View 6 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
hbos
Please take a look, hta.
3 years, 9 months ago (2017-02-28 14:25:11 UTC) #5
hta-webrtc
lgtm
3 years, 9 months ago (2017-02-28 19:38:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2722633005/1
3 years, 9 months ago (2017-03-01 09:00:43 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 09:02:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a7a9be159df454db9d861b49b...

Powered by Google App Engine
This is Rietveld 408576698