Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: webrtc/pc/rtcstats_integrationtest.cc

Issue 2722633005: Move RTCOutboundRTPStreamStats.roundTripTime to inbound, don't collect. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/stats/rtcstats_objects.h ('k') | webrtc/pc/rtcstatscollector.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 534 matching lines...) Expand 10 before | Expand all | Expand 10 after
545 verifier.TestMemberIsNonNegative<uint32_t>(inbound_stream.packets_received); 545 verifier.TestMemberIsNonNegative<uint32_t>(inbound_stream.packets_received);
546 verifier.TestMemberIsNonNegative<uint64_t>(inbound_stream.bytes_received); 546 verifier.TestMemberIsNonNegative<uint64_t>(inbound_stream.bytes_received);
547 verifier.TestMemberIsNonNegative<uint32_t>(inbound_stream.packets_lost); 547 verifier.TestMemberIsNonNegative<uint32_t>(inbound_stream.packets_lost);
548 if (inbound_stream.media_type.is_defined() && 548 if (inbound_stream.media_type.is_defined() &&
549 *inbound_stream.media_type == "video") { 549 *inbound_stream.media_type == "video") {
550 verifier.TestMemberIsUndefined(inbound_stream.jitter); 550 verifier.TestMemberIsUndefined(inbound_stream.jitter);
551 } else { 551 } else {
552 verifier.TestMemberIsNonNegative<double>(inbound_stream.jitter); 552 verifier.TestMemberIsNonNegative<double>(inbound_stream.jitter);
553 } 553 }
554 verifier.TestMemberIsNonNegative<double>(inbound_stream.fraction_lost); 554 verifier.TestMemberIsNonNegative<double>(inbound_stream.fraction_lost);
555 verifier.TestMemberIsUndefined(inbound_stream.round_trip_time);
555 verifier.TestMemberIsUndefined(inbound_stream.packets_discarded); 556 verifier.TestMemberIsUndefined(inbound_stream.packets_discarded);
556 verifier.TestMemberIsUndefined(inbound_stream.packets_repaired); 557 verifier.TestMemberIsUndefined(inbound_stream.packets_repaired);
557 verifier.TestMemberIsUndefined(inbound_stream.burst_packets_lost); 558 verifier.TestMemberIsUndefined(inbound_stream.burst_packets_lost);
558 verifier.TestMemberIsUndefined(inbound_stream.burst_packets_discarded); 559 verifier.TestMemberIsUndefined(inbound_stream.burst_packets_discarded);
559 verifier.TestMemberIsUndefined(inbound_stream.burst_loss_count); 560 verifier.TestMemberIsUndefined(inbound_stream.burst_loss_count);
560 verifier.TestMemberIsUndefined(inbound_stream.burst_discard_count); 561 verifier.TestMemberIsUndefined(inbound_stream.burst_discard_count);
561 verifier.TestMemberIsUndefined(inbound_stream.burst_loss_rate); 562 verifier.TestMemberIsUndefined(inbound_stream.burst_loss_rate);
562 verifier.TestMemberIsUndefined(inbound_stream.burst_discard_rate); 563 verifier.TestMemberIsUndefined(inbound_stream.burst_discard_rate);
563 verifier.TestMemberIsUndefined(inbound_stream.gap_loss_rate); 564 verifier.TestMemberIsUndefined(inbound_stream.gap_loss_rate);
564 verifier.TestMemberIsUndefined(inbound_stream.gap_discard_rate); 565 verifier.TestMemberIsUndefined(inbound_stream.gap_discard_rate);
(...skipping 12 matching lines...) Expand all
577 VerifyRTCRTPStreamStats(outbound_stream, &verifier); 578 VerifyRTCRTPStreamStats(outbound_stream, &verifier);
578 if (outbound_stream.media_type.is_defined() && 579 if (outbound_stream.media_type.is_defined() &&
579 *outbound_stream.media_type == "video") { 580 *outbound_stream.media_type == "video") {
580 verifier.TestMemberIsNonNegative<uint64_t>(outbound_stream.qp_sum); 581 verifier.TestMemberIsNonNegative<uint64_t>(outbound_stream.qp_sum);
581 } else { 582 } else {
582 verifier.TestMemberIsUndefined(outbound_stream.qp_sum); 583 verifier.TestMemberIsUndefined(outbound_stream.qp_sum);
583 } 584 }
584 verifier.TestMemberIsNonNegative<uint32_t>(outbound_stream.packets_sent); 585 verifier.TestMemberIsNonNegative<uint32_t>(outbound_stream.packets_sent);
585 verifier.TestMemberIsNonNegative<uint64_t>(outbound_stream.bytes_sent); 586 verifier.TestMemberIsNonNegative<uint64_t>(outbound_stream.bytes_sent);
586 verifier.TestMemberIsUndefined(outbound_stream.target_bitrate); 587 verifier.TestMemberIsUndefined(outbound_stream.target_bitrate);
587 // TODO(hbos): Defined in video but not audio case. Why? crbug.com/669877
588 verifier.MarkMemberTested(outbound_stream.round_trip_time, true);
589 if (outbound_stream.media_type.is_defined() && 588 if (outbound_stream.media_type.is_defined() &&
590 *outbound_stream.media_type == "video") { 589 *outbound_stream.media_type == "video") {
591 verifier.TestMemberIsDefined(outbound_stream.frames_encoded); 590 verifier.TestMemberIsDefined(outbound_stream.frames_encoded);
592 } else { 591 } else {
593 verifier.TestMemberIsUndefined(outbound_stream.frames_encoded); 592 verifier.TestMemberIsUndefined(outbound_stream.frames_encoded);
594 } 593 }
595 return verifier.ExpectAllMembersSuccessfullyTested(); 594 return verifier.ExpectAllMembersSuccessfullyTested();
596 } 595 }
597 596
598 bool VerifyRTCTransportStats( 597 bool VerifyRTCTransportStats(
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
645 // Any pending stats requests should have completed in the act of destroying 644 // Any pending stats requests should have completed in the act of destroying
646 // the peer connection. 645 // the peer connection.
647 EXPECT_TRUE(stats_obtainer->report()); 646 EXPECT_TRUE(stats_obtainer->report());
648 } 647 }
649 #endif // HAVE_SCTP 648 #endif // HAVE_SCTP
650 #endif // !defined(THREAD_SANITIZER) 649 #endif // !defined(THREAD_SANITIZER)
651 650
652 } // namespace 651 } // namespace
653 652
654 } // namespace webrtc 653 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/api/stats/rtcstats_objects.h ('k') | webrtc/pc/rtcstatscollector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698